Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added IoC example #3595

Merged
merged 2 commits into from
Jan 31, 2018
Merged

Added IoC example #3595

merged 2 commits into from
Jan 31, 2018

Conversation

alexindigo
Copy link
Contributor

Showing off Dependency Injection approach, we're taking at Trulia. Wanted to create something generic and not coupled with our internal things. And the best way is to have working example in the public repo. Thank you.

@arunoda @timneutkens @rauchg
@mtoso @dntrkv

timneutkens
timneutkens approved these changes Jan 30, 2018
View reviewed changes
Copy link
Member

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@alexindigo
Copy link
Contributor Author

@timneutkens Thanks. Rebased.

@timneutkens timneutkens merged commit e401e2c into vercel:canary Jan 31, 2018
@timneutkens
Copy link
Member

Thanks @alexindigo 🙏

@alexindigo alexindigo deleted the with-ioc branch January 31, 2018 07:50
@lock lock bot locked as resolved and limited conversation to collaborators Jan 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alexindigo @timneutkens