Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to with-supertokens example #35991

Merged
merged 118 commits into from Apr 11, 2022
Merged

Update to with-supertokens example #35991

merged 118 commits into from Apr 11, 2022

Conversation

rishabhpoddar
Copy link
Contributor

@rishabhpoddar rishabhpoddar commented Apr 8, 2022 •
edited

  • Upgrades to latest version of supertokens-auth-react SDK
  • Adds next.config.js file

NkxxkN and others added 30 commits February 16, 2021 15:21
add-supertokens-to-authentication.md
7e044a9
Merge branch 'canary' into with-supertokens-example-in-docs
8e5bd92
@kant01ne
bump supertokens deps
e290993
@kant01ne
update SuperTokens Auth doc
0fecb52
Merge branch 'canary' into with-supertokens-example-in-docs
055047b
@leerob
Update docs/authentication.md
49caedd 
Co-authored-by: Lee Robinson <me@leerob.io>
@leerob
Update docs/authentication.md
a00f6a5 
Co-authored-by: Lee Robinson <me@leerob.io>
@rishabhpoddar
updates supertokens dependency and optimises for serverless execution
fa05b78
@rishabhpoddar
updates with original repo
0af47ee
@rishabhpoddar
runs prettier-fix
feab6fb
@rishabhpoddar
Merge branch 'canary' into canary
5d8c319
@rishabhpoddar
adds supertokens to 'Bring Your Own Database' section as well
7a50823
@rishabhpoddar
Merge branch 'canary' into canary
05795a5
@rishabhpoddar
does not show home page if not logged in
b44c159
@rishabhpoddar
extracts config into its own file and calls it in all serverless func…
ca44249 
…tions
@rishabhpoddar
removes need for backend init in app.jsx
13ad8f2
@rishabhpoddar
simplifies use of dynamic
83a8369
@rishabhpoddar
Merge branch 'canary' into canary
88f9193
@rishabhpoddar
refreshes page after getServerSideProps
39a850e
@rishabhpoddar
removes unnecessary check in API
1007e80
@rishabhpoddar
Merge branch 'canary' into canary
d0c8a19
@rishabhpoddar
update to docs pertaining SuperTokens
6f05b35
@rishabhpoddar
adds placeholder secrets so that the UI loads on first run
80e72e9
@rishabhpoddar
changes to readme
bbf27a2
@rishabhpoddar
updates version of supertokens frontend and backend SDK, and a few ot…
52e423b 
…her fixes
@rishabhpoddar
Merge branch 'canary' into canary
93b6588
@rishabhpoddar @leerob
Update docs/authentication.md
c88554b 
Co-authored-by: Lee Robinson <me@leerob.io>
@rishabhpoddar
Merge branch 'canary' into canary
121c5ae
@rishabhpoddar
Merge branch 'canary' into canary
3f8906b
@rishabhpoddar
updates to readme for supertokens example
5c7bf78
@ijjk ijjk added the examples Issue/PR related to examples label Apr 8, 2022
@rishabhpoddar rishabhpoddar marked this pull request as ready for review April 8, 2022 09:17
@rishabhpoddar @balazsorban44
Update examples/with-supertokens/package.json
66c16d7 
Co-authored-by: Balázs Orbán <info@balazsorban.com>
balazsorban44
balazsorban44 requested changes Apr 11, 2022
View reviewed changes
Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small comment, and a note, there is no need to keep merging canary, as it does not really affect the PR. 👍

We have an ESLint example https://github.com/vercel/next.js/tree/canary/examples/with-eslint so no need to add it here.

rishabhpoddar and others added 2 commits April 11, 2022 15:17
@rishabhpoddar
Copy link
Contributor Author

Just a small comment, and a note, there is no need to keep merging canary, as it does not really affect the PR.

Well yea... sometimes even after the PR has been approved, and the checks all pass, it doesn't auto merge cause my repo is out of date from canary.

@balazsorban44 balazsorban44 merged commit 3931888 into vercel:canary Apr 11, 2022
@snyk-bot snyk-bot mentioned this pull request May 4, 2022
Open
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@balazsorban44 balazsorban44 balazsorban44 approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

@ijjk ijjk Awaiting requested review from ijjk

@shuding shuding Awaiting requested review from shuding

@leerob leerob Awaiting requested review from leerob

@steven-tey steven-tey Awaiting requested review from steven-tey

Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@rishabhpoddar @balazsorban44 @ijjk @kant01ne @bhumilsarvaiya @jscyo