Improved next/asset support #3664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now we use webpack's publicPath via client side.
arunoda
commented
Feb 2, 2018
| // With this, static assets will work across zones | ||
| // With dynamic assetPrefix it's no longer possible to set assetPrefix at the build time | ||
| // So, this is how we do it in the client side at runtime | ||
| __webpack_public_path__ = `${assetPrefix}/_next/webpack/` //eslint-disable-line |
There was a problem hiding this comment.
@timneutkens have a look at this.
This is a public API: https://webpack.js.org/guides/public-path/#on-the-fly
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the behaviour of
next/assetAlso added test cases for above scenarios.