Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enforce omitting name and version #36771

Merged
merged 2 commits into from May 9, 2022
Merged

Conversation

balazsorban44
Copy link
Member

We have tests running on the examples repository that will fail if name or version is found in the package.json. We should make it more clear in the documentation to omit these fields.

@ijjk

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk
Copy link
Member

ijjk commented May 9, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js docs/enforce-omitting-fields Change
buildDuration 20s 20.1s ⚠️ +164ms
buildDurationCached 7.6s 7.6s -41ms
nodeModulesSize 475 MB 475 MB
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js docs/enforce-omitting-fields Change
/ failed reqs 0 0
/ total time (seconds) 4.935 5.131 ⚠️ +0.2
/ avg req/sec 506.58 487.25 ⚠️ -19.33
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.871 1.741 -0.13
/error-in-render avg req/sec 1335.84 1436.27 +100.43
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js docs/enforce-omitting-fields Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 28.8 kB 28.8 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.5 kB 72.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js docs/enforce-omitting-fields Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js docs/enforce-omitting-fields Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 308 B 308 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.69 kB 2.69 kB
head-HASH.js gzip 359 B 359 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.7 kB 5.7 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.64 kB 2.64 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 391 B 391 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 15.9 kB 15.9 kB
Client Build Manifests
vercel/next.js canary vercel/next.js docs/enforce-omitting-fields Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js docs/enforce-omitting-fields Change
index.html gzip 532 B 532 B
link.html gzip 546 B 546 B
withRouter.html gzip 528 B 528 B
Overall change 1.61 kB 1.61 kB

Default Build with SWC (Decrease detected ✓)
General
vercel/next.js canary vercel/next.js docs/enforce-omitting-fields Change
buildDuration 22s 22s -45ms
buildDurationCached 7.8s 7.7s -68ms
nodeModulesSize 475 MB 475 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js docs/enforce-omitting-fields Change
/ failed reqs 0 0
/ total time (seconds) 4.988 5.119 ⚠️ +0.13
/ avg req/sec 501.18 488.35 ⚠️ -12.83
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.806 1.861 ⚠️ +0.05
/error-in-render avg req/sec 1384.19 1343.41 ⚠️ -40.78
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js docs/enforce-omitting-fields Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 29.2 kB 29.2 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 73.1 kB 73.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js docs/enforce-omitting-fields Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js docs/enforce-omitting-fields Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 324 B 324 B
dynamic-HASH.js gzip 2.71 kB 2.71 kB
head-HASH.js gzip 357 B 357 B
hooks-HASH.js gzip 921 B 921 B
image-HASH.js gzip 5.79 kB 5.79 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.76 kB 2.76 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 392 B 392 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16.1 kB 16.1 kB
Client Build Manifests
vercel/next.js canary vercel/next.js docs/enforce-omitting-fields Change
_buildManifest.js gzip 456 B 456 B
Overall change 456 B 456 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js docs/enforce-omitting-fields Change
index.html gzip 529 B 529 B
link.html gzip 543 B 543 B
withRouter.html gzip 526 B 526 B
Overall change 1.6 kB 1.6 kB
Commit: b201e67

@kodiakhq kodiakhq bot merged commit 6aa9ef1 into canary May 9, 2022
@kodiakhq kodiakhq bot deleted the docs/enforce-omitting-fields branch May 9, 2022 11:27
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants