Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: improve remotePatterns wildcard matching #37026

Closed
wants to merge 1 commit into from

Conversation

styfle
Copy link
Member

@styfle styfle commented May 18, 2022

Work in progress

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels May 18, 2022
@ijjk
Copy link
Member

ijjk commented May 18, 2022

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js image-remotepatterns-single-asterisk-wildcard Change
buildDuration 15.7s 15.6s -119ms
buildDurationCached 6.3s 6.5s ⚠️ +200ms
nodeModulesSize 478 MB 478 MB ⚠️ +1.7 kB
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js image-remotepatterns-single-asterisk-wildcard Change
/ failed reqs 0 0
/ total time (seconds) 3.87 3.855 -0.02
/ avg req/sec 646.02 648.56 +2.54
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.335 1.292 -0.04
/error-in-render avg req/sec 1872.27 1935.52 +63.25
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js image-remotepatterns-single-asterisk-wildcard Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 28.8 kB 28.8 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.4 kB 72.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js image-remotepatterns-single-asterisk-wildcard Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js image-remotepatterns-single-asterisk-wildcard Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 308 B 308 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.71 kB 2.71 kB
head-HASH.js gzip 359 B 359 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.73 kB 5.73 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.65 kB 2.65 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 391 B 391 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16 kB 16 kB
Client Build Manifests
vercel/next.js canary vercel/next.js image-remotepatterns-single-asterisk-wildcard Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js image-remotepatterns-single-asterisk-wildcard Change
index.html gzip 531 B 531 B
link.html gzip 545 B 545 B
withRouter.html gzip 528 B 528 B
Overall change 1.6 kB 1.6 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js image-remotepatterns-single-asterisk-wildcard Change
buildDuration 18.9s 18.7s -245ms
buildDurationCached 6.5s 6.5s -22ms
nodeModulesSize 478 MB 478 MB ⚠️ +1.7 kB
Page Load Tests Overall increase ✓
vercel/next.js canary vercel/next.js image-remotepatterns-single-asterisk-wildcard Change
/ failed reqs 0 0
/ total time (seconds) 4.022 3.977 -0.05
/ avg req/sec 621.59 628.55 +6.96
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.411 1.397 -0.01
/error-in-render avg req/sec 1771.74 1789.52 +17.78
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js image-remotepatterns-single-asterisk-wildcard Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.7 kB 42.7 kB
main-HASH.js gzip 29.2 kB 29.2 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 73.5 kB 73.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js image-remotepatterns-single-asterisk-wildcard Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js image-remotepatterns-single-asterisk-wildcard Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 311 B 311 B
css-HASH.js gzip 324 B 324 B
dynamic-HASH.js gzip 2.89 kB 2.89 kB
head-HASH.js gzip 357 B 357 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.82 kB 5.82 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.78 kB 2.78 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 392 B 392 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16.3 kB 16.3 kB
Client Build Manifests
vercel/next.js canary vercel/next.js image-remotepatterns-single-asterisk-wildcard Change
_buildManifest.js gzip 457 B 457 B
Overall change 457 B 457 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js image-remotepatterns-single-asterisk-wildcard Change
index.html gzip 531 B 531 B
link.html gzip 546 B 546 B
withRouter.html gzip 528 B 528 B
Overall change 1.6 kB 1.6 kB
Commit: a29f77b

@kodiakhq kodiakhq bot closed this in #37137 May 25, 2022
kodiakhq bot pushed a commit that referenced this pull request May 25, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants