Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add swcMinifyDebugOptions #37172

Merged
merged 19 commits into from
May 29, 2022
Merged

Add swcMinifyDebugOptions #37172

merged 19 commits into from
May 29, 2022

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented May 25, 2022

This also updates swc crates to swc-project/swc@7eac561

@ijjk
Copy link
Member

ijjk commented May 25, 2022

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary kdy1/next.js swc-up-6 Change
buildDuration 16.7s 16.8s ⚠️ +27ms
buildDurationCached 6.8s 6.6s -166ms
nodeModulesSize 634 MB 634 MB ⚠️ +2.23 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary kdy1/next.js swc-up-6 Change
/ failed reqs 0 0
/ total time (seconds) 3.973 4.027 ⚠️ +0.05
/ avg req/sec 629.17 620.88 ⚠️ -8.29
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.374 1.397 ⚠️ +0.02
/error-in-render avg req/sec 1819.28 1789.21 ⚠️ -30.07
Client Bundles (main, webpack)
vercel/next.js canary kdy1/next.js swc-up-6 Change
925.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42 kB 42 kB
main-HASH.js gzip 29.2 kB 29.2 kB
webpack-HASH.js gzip 1.54 kB 1.54 kB
Overall change 73 kB 73 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary kdy1/next.js swc-up-6 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary kdy1/next.js swc-up-6 Change
_app-HASH.js gzip 1.36 kB 1.36 kB
_error-HASH.js gzip 193 B 193 B
amp-HASH.js gzip 308 B 308 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.7 kB 2.7 kB
head-HASH.js gzip 359 B 359 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.74 kB 5.74 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 2.65 kB 2.65 kB
routerDirect..HASH.js gzip 320 B 320 B
script-HASH.js gzip 391 B 391 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16 kB 16 kB
Client Build Manifests
vercel/next.js canary kdy1/next.js swc-up-6 Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary kdy1/next.js swc-up-6 Change
index.html gzip 533 B 533 B
link.html gzip 547 B 547 B
withRouter.html gzip 528 B 528 B
Overall change 1.61 kB 1.61 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary kdy1/next.js swc-up-6 Change
buildDuration 19.1s 19s -64ms
buildDurationCached 6.6s 6.5s -48ms
nodeModulesSize 634 MB 634 MB ⚠️ +2.23 kB
Page Load Tests Overall increase ✓
vercel/next.js canary kdy1/next.js swc-up-6 Change
/ failed reqs 0 0
/ total time (seconds) 4.032 3.949 -0.08
/ avg req/sec 620.1 633.09 +12.99
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.408 1.38 -0.03
/error-in-render avg req/sec 1775.07 1811.3 +36.23
Client Bundles (main, webpack)
vercel/next.js canary kdy1/next.js swc-up-6 Change
925.HASH.js gzip 178 B 178 B
framework-HASH.js gzip 42.7 kB 42.7 kB
main-HASH.js gzip 29.7 kB 29.7 kB
webpack-HASH.js gzip 1.54 kB 1.54 kB
Overall change 74.1 kB 74.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary kdy1/next.js swc-up-6 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary kdy1/next.js swc-up-6 Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 311 B 311 B
css-HASH.js gzip 324 B 324 B
dynamic-HASH.js gzip 2.9 kB 2.9 kB
head-HASH.js gzip 357 B 357 B
hooks-HASH.js gzip 920 B 920 B
image-HASH.js gzip 5.84 kB 5.84 kB
index-HASH.js gzip 261 B 261 B
link-HASH.js gzip 2.78 kB 2.78 kB
routerDirect..HASH.js gzip 322 B 322 B
script-HASH.js gzip 392 B 392 B
withRouter-HASH.js gzip 317 B 317 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 16.4 kB 16.4 kB
Client Build Manifests
vercel/next.js canary kdy1/next.js swc-up-6 Change
_buildManifest.js gzip 458 B 458 B
Overall change 458 B 458 B
Rendered Page Sizes
vercel/next.js canary kdy1/next.js swc-up-6 Change
index.html gzip 532 B 532 B
link.html gzip 547 B 547 B
withRouter.html gzip 528 B 528 B
Overall change 1.61 kB 1.61 kB
Commit: 5771fef

kdy1 and others added 3 commits May 25, 2022 23:59
Co-authored-by: Tim Neutkens <tim@timneutkens.nl>
ijjk and others added 4 commits May 28, 2022 21:52
# Conflicts:
#	packages/next-swc/crates/napi/Cargo.toml
#	packages/next/server/config-shared.ts
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kodiakhq kodiakhq bot merged commit 748ce12 into vercel:canary May 29, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 28, 2022
@kdy1 kdy1 deleted the swc-up-6 branch July 6, 2022 03:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants