Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Script] Updates stale no-script-in-document-page error doc #37568

Merged
merged 3 commits into from Jun 13, 2022
Merged

[Script] Updates stale no-script-in-document-page error doc #37568

merged 3 commits into from Jun 13, 2022

Conversation

housseindjirdeh
Copy link
Collaborator

Recent changes to next/script introduced the capability to use beforeInteractive scripts in the custom document. This old error message is incorrect.

@ijjk ijjk added area: documentation created-by: Chrome Aurora PRs by the Google Chrome team: https://web.dev/aurora labels Jun 8, 2022
ijjk
ijjk reviewed Jun 8, 2022
View reviewed changes
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably want to keep this document for older Next.js versions, we can add a link to the new doc if that helps?

@housseindjirdeh housseindjirdeh force-pushed the remove-no-script-in-document-error-doc branch from a031aeb to 54984ff Compare June 9, 2022 16:33
@housseindjirdeh housseindjirdeh force-pushed the remove-no-script-in-document-error-doc branch from 54984ff to 688232a Compare June 9, 2022 16:34
@housseindjirdeh
Copy link
Collaborator Author

Ah good point. Updated it and included a note with a link to the new doc for folks using a newer Next.js version.

@housseindjirdeh housseindjirdeh changed the title [Script] Removes stale no-script-in-document-page error doc [Script] Updates stale no-script-in-document-page error doc Jun 9, 2022
ijjk
ijjk approved these changes Jun 13, 2022
View reviewed changes
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kodiakhq kodiakhq bot merged commit 2eb48e7 into vercel:canary Jun 13, 2022
@manovotny manovotny mentioned this pull request Jun 13, 2022
Merged
3 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

@shuding shuding Awaiting requested review from shuding

@huozhi huozhi Awaiting requested review from huozhi

Assignees
No one assigned
Labels
created-by: Chrome Aurora PRs by the Google Chrome team: https://web.dev/aurora
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@housseindjirdeh @ijjk