Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Revert "Revert "Avoid unnecessary router state changes""" #37692

Merged
merged 1 commit into from Jun 14, 2022
Merged

Revert "Revert "Revert "Avoid unnecessary router state changes""" #37692

merged 1 commit into from Jun 14, 2022

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Jun 14, 2022 •
edited

It seems there are still some edge cases we will need to investigate further so this reverts this optimization for now.

Reverts #37593

x-ref: slack thread

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Jun 14, 2022
@ijjk ijjk marked this pull request as ready for review June 14, 2022 16:38
@ijjk ijjk merged commit a01aa4d into canary Jun 14, 2022
@ijjk ijjk deleted the revert-37593-revert-37572-revert-37431-shu/e812 branch June 14, 2022 17:00
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

@shuding shuding Awaiting requested review from shuding shuding is a code owner

@huozhi huozhi Awaiting requested review from huozhi huozhi is a code owner

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ijjk