Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(examples): Convert api-routes-apollo-server example to TypeScript #38315

Conversation

maxproske
Copy link
Contributor

Convert api-routes-apollo-server example to TypeScript to match Contribution docs.

Documentation / Examples

  • Make sure the linting passes by running pnpm lint
  • The examples guidelines are followed from our contributing doc

@ijjk ijjk added the examples Issue/PR related to examples label Jul 5, 2022
@maxproske maxproske changed the title Convert api-routes-apollo-server example to TypeScript chore(examples): Convert api-routes-apollo-server example to TypeScript Jul 6, 2022
@maxproske maxproske changed the title chore(examples): Convert api-routes-apollo-server example to TypeScript chore(examples): Convert api-routes-apollo-server example to TypeScript Jul 6, 2022
@balazsorban44
Copy link
Member

So this supersedes #30082?

@balazsorban44
Copy link
Member

I wonder if this is an opportunity to merge api-routes-apollo-server-and-client-auth, api-routes-apollo-server-and-client and api-routes-apollo-server to a single example. What do you think? 🤔

@maxproske
Copy link
Contributor Author

Closing this for now. Got feedback from a maintainer of Apollo Server #30082 (comment)

It sounds like upon release of Apollo Server 4, all Apollo examples should be merged into as few examples as possible, using apollo-server-express and TypeScript.

@maxproske maxproske closed this Jul 8, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants