Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

with-firebase-hosting improvements & fixes #3886

Merged
merged 8 commits into from Feb 28, 2018
Merged

with-firebase-hosting improvements & fixes #3886

merged 8 commits into from Feb 28, 2018

Conversation

jthegedus
Copy link
Contributor

Fixes #3640 (comment)

  • Added _document.js & _error.js page to the pages/ to remove 404/500 errors.
  • Updated deps to latest
  • Consolidated all package.json files into a single root level file. This removed the need for this previous caveat:

    Any npm modules dependencies used in the Next.js app (app/ folder) must also be installed as dependencies for the Cloud Functions project (functions folder).

  • Removed the need for any postinstall npm scripts
  • Added babel compilation for functions/ which runs independently of the next.js babel compilation.
  • use Firebase predeploy hooks to run the required npm scripts when npm run deploy runs firebase deploy.

@jthegedus
Copy link
Contributor Author

@timneutkens Could you shed any light on why the update to Next.js v5 would force the requirement of _error.js and _document.js as per #3640 (comment) ?

Was there a change in the output dir? Or are they not built on the initial / page load anymore?

@timneutkens
Copy link
Member

@jthegedus it's fixed in canary there was a flaw in the externals logic.

@jthegedus
Copy link
Contributor Author

jthegedus commented Feb 25, 2018

Ah okay, thanks for the confirmation 😃

When that's published we can remove those two pages from this PR and merge it 👍

@timneutkens
Copy link
Member

@jthegedus please remove the right now, then I'll merge the example. We install next@latest always in package.json, so when it's out I can merge this example immediately 👍

@timneutkens timneutkens merged commit b4b5b1f into vercel:canary Feb 28, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Feb 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants