FIX deploy with-firebase-hosting #3946
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,7 +7,8 @@ | |
| "dev": "next src/app", | ||
| "serve": | ||
| "echo \"for details see:\n\thttps://github.com/firebase/firebase-tools/issues/535 \n\thttps://github.com/zeit/next.js/issues/3167\";", | ||
| "predeploy": "mkdir -p \"dist/functions\"", | ||
| "deploy": "cd \"dist/functions\" && firebase deploy", | ||
|
There was a problem hiding this comment. and this shouldn't be required either because https://github.com/zeit/next.js/blob/76582b8e437dadc4dce18ec6ee525acb6f0d2cdb/examples/with-firebase-hosting/firebase.json#L13 should be picked up on And moving dir might mess up the deployment step of any hosting or db parts of the deployment. There was a problem hiding this comment. I don't know why...but this doesn't work for me... |
||
| "clean": "rimraf \"dist/functions\" && rimraf \"dist/public\"", | ||
| "build-public": "cpx \"src/public/**/*.*\" \"dist/public\" -C", | ||
| "build-funcs": "babel \"src/functions\" --out-dir \"dist/functions\"", | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shouldn't need this as
build-funcswill create this when run.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but we must run
firebase deployindist/functionsfor fix the problem. If i runyarn cleanand aftercd \"dist/functions\" && firebase deploy, we have an error becausedist/functionsnot exists.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It errors because after you
cdintodist/functionsfirebase deploytries to deploy a directory calleddist/functionswhich doesn't exist from the relative directory ofdist/functions.firebase deployknows to deploydist/functionsfrom https://github.com/zeit/next.js/pull/3946/files#diff-0bde36a03f5abc11a925591823b9d3c2R13