Add flow, pages-manifest.json, defaultPathMap for export (minor) #4066
Conversation
timneutkens
changed the title
next export to be ran without exportPathMap (minor)
timneutkens
changed the title
.flowconfig
Outdated
| @@ -0,0 +1,3 @@ | |||
| [ignore] | |||
| <PROJECT_ROOT>/examples/.* | |||
| <PROJECT_ROOT>/examples/.* | |||
There was a problem hiding this comment.
Why two instances of this?
| import { MATCH_ROUTE_NAME } from '../../utils' | ||
| import {PAGES_MANIFEST} from '../../../lib/constants' | ||
|
|
||
| export default class PagesManifestPlugin { |
There was a problem hiding this comment.
Shall we add a comment on what this plugin is about
| '> "next export" uses that function to build html pages.' | ||
| ) | ||
| console.log('> No "exportPathMap" found in "next.config.js". Generating map from "./pages"') | ||
| nextConfig.exportPathMap = async (defaultMap) => { |
There was a problem hiding this comment.
Log a message on this is exporting all the pages or something similar.
There was a problem hiding this comment.
Generating map from "./pages" seems clear to me 馃 @rauchg wrote the specific text update.
There was a problem hiding this comment.
I mean the Generating map from "./pages".
It's bit of unclear what's map is. If the user created the exportPathMap before it's clear.
Otherwise, he/she might be looking at what's this map is.
| @@ -1,5 +1,5 @@ | |||
| import {join, parse, normalize, sep} from 'path' | |||
| import fs from 'mz/fs' | |||
There was a problem hiding this comment.
Can we remove mz with this change?
There was a problem hiding this comment.
No, it's still used, but there's another PR to remove it.
pages-manifest.jsonthat holds a mapping ofpage => js-filethis is now used for resolving pages inrequire.jsand to generate thedefaultPathMapfornext export. It also gives a major performance boost (again) because we don't have to hit the filesystem for non-existent pages 馃憣defaultPathMapbased onpages-manifest.jsonnext exportto be ran withoutexportPathMap