Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update with-apollo examples #4067

Merged
merged 2 commits into from
Mar 28, 2018
Merged

Update with-apollo examples #4067

merged 2 commits into from
Mar 28, 2018

Conversation

willmeierart
Copy link
Contributor

pull request as per suggestion from @ads1018 in #2214

jthegedus
jthegedus approved these changes Mar 28, 2018
View reviewed changes
Copy link
Contributor

@jthegedus jthegedus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@willmeierart
Copy link
Contributor Author

willmeierart commented Mar 28, 2018 •
edited
Loading

@jthegedus I think this may have gotten held up due to the first commit of the two not passing a review

@timneutkens
Copy link
Member

@willmeierart mostly because I just didn't get to it yet 😄 looks good!

@timneutkens timneutkens merged commit 4570f2d into vercel:canary Mar 28, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Mar 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

@jthegedus jthegedus jthegedus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@willmeierart @timneutkens @jthegedus