New example: with-now-env #4073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timneutkens
reviewed
Mar 28, 2018
| webpack: config => { | ||
| config.plugins.forEach(plugin => { | ||
| if (plugin.constructor.name === 'DefinePlugin') { | ||
| plugin.definitions['process.env.SECRET'] = JSON.stringify(process.env.SECRET) |
There was a problem hiding this comment.
Why not just do another defineplugin, is much more readable and future proof.
There was a problem hiding this comment.
Instead of DefinePlugin you could have use EnvironmentPlugin and just do:
new webpack.EnvironmentPlugin(['SECRET'])That will automatically define process.env.SECRET 😉
There was a problem hiding this comment.
@sergiodxa I like explicit mapping though. Especially since this ends up in client bundles.
timneutkens
approved these changes
Mar 28, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.