-
Notifications
You must be signed in to change notification settings - Fork 26.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(examples): add webiny cms example #41159
chore(examples): add webiny cms example #41159
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some comments.
React
imports are unnecessary unless you access a method like React.useState
or types. In most cases, I could not see that, so please remove those imports from files (even if I did not request the change).
Co-authored-by: Balázs Orbán <info@balazsorban.com>
Co-authored-by: Balázs Orbán <info@balazsorban.com>
Co-authored-by: Balázs Orbán <info@balazsorban.com>
Thanks for your help @balazsorban44, the only thing I wasn't able to do was remove |
Hey @balazsorban44, any other way around the react imports thing? I'd really like to get a clear way forward for this PR. |
You forgot to add a |
Thanks for the PR! |
Merged manually, since |
Thanks @balazsorban44 |
## Documentation / Examples - [X] Make sure the linting passes by running `pnpm lint` - [X] The "examples guidelines" are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md) Co-authored-by: Balázs Orbán <info@balazsorban.com>
## Documentation / Examples - [X] Make sure the linting passes by running `pnpm lint` - [X] The "examples guidelines" are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md) Co-authored-by: Balázs Orbán <info@balazsorban.com>
Documentation / Examples
pnpm lint