Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added example of integration with videojs #4139

Merged
merged 6 commits into from
Apr 12, 2018
Merged

added example of integration with videojs #4139

merged 6 commits into from
Apr 12, 2018

Conversation

prateekrastogi
Copy link

No description provided.

@timneutkens
Copy link
Member

PR looks great, please run yarn lint --fix 👍 Then I'll merge

@timneutkens
Copy link
Member

Also, you don't have to close pull requests to update them. Just push to the branch 👍

@prateekrastogi
Copy link
Author

Hi,
Thanks for informing about pull. I ran the linter to fix it. Funnily, the linter was not detecting files in pages folder while properly detecting all the files in components folder. Hence, causing linting issues.

@@ -1 +0,0 @@
../../
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should definitely not be removed.

Prateek Rastogi added 2 commits April 12, 2018 15:10
Copy link
Member

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@timneutkens timneutkens merged commit fbd023c into vercel:canary Apr 12, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Apr 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants