Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable ReactRefreshLogBox-builtins.test.ts, remove loader from import trace #41645

Merged
merged 1 commit into from
Oct 22, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ export async function getNotFoundError(
.filter(
(name) =>
name &&
!/next-(middleware|client-pages|flight-(client|server))-loader\.js/.test(
!/next-(middleware|client-pages|flight-(client|server|client-entry))-loader\.js/.test(
name
)
)
Expand Down
4 changes: 4 additions & 0 deletions test/development/acceptance-app/ReactRefresh.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,10 @@ describe('ReactRefresh app', () => {
beforeAll(async () => {
next = await createNext({
files: new FileRef(path.join(__dirname, 'fixtures', 'default-template')),
dependencies: {
react: '0.0.0-experimental-9cdf8a99e-20221018',
'react-dom': '0.0.0-experimental-9cdf8a99e-20221018',
},
skipStart: true,
})
})
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { NextInstance } from 'test/lib/next-modes/base'
import path from 'path'

// TODO-APP: Investigate snapshot mismatch
describe.skip('ReactRefreshLogBox app', () => {
describe('ReactRefreshLogBox app', () => {
if (process.env.NEXT_TEST_REACT_VERSION === '^17') {
it('should skip for react v17', () => {})
return
Expand All @@ -15,6 +15,10 @@ describe.skip('ReactRefreshLogBox app', () => {
beforeAll(async () => {
next = await createNext({
files: new FileRef(path.join(__dirname, 'fixtures', 'default-template')),
dependencies: {
react: '0.0.0-experimental-9cdf8a99e-20221018',
'react-dom': '0.0.0-experimental-9cdf8a99e-20221018',
},
skipStart: true,
})
})
Expand Down Expand Up @@ -109,7 +113,7 @@ describe.skip('ReactRefreshLogBox app', () => {
await cleanup()
})

test('Module not found (missing global CSS)', async () => {
test('Module not found missing global CSS', async () => {
const { session, cleanup } = await sandbox(
next,
new Map([
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ describe.skip('ReactRefreshLogBox app', () => {
skipStart: true,
dependencies: {
sass: 'latest',
react: '0.0.0-experimental-9cdf8a99e-20221018',
'react-dom': '0.0.0-experimental-9cdf8a99e-20221018',
},
})
})
Expand Down
4 changes: 4 additions & 0 deletions test/development/acceptance-app/ReactRefreshLogBox.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,10 @@ describe('ReactRefreshLogBox app', () => {
beforeAll(async () => {
next = await createNext({
files: new FileRef(path.join(__dirname, 'fixtures', 'default-template')),
dependencies: {
react: '0.0.0-experimental-9cdf8a99e-20221018',
'react-dom': '0.0.0-experimental-9cdf8a99e-20221018',
},
skipStart: true,
})
})
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,10 @@ describe.skip('ReactRefreshLogBox app', () => {
beforeAll(async () => {
next = await createNext({
files: new FileRef(path.join(__dirname, 'fixtures', 'default-template')),
dependencies: {
react: '0.0.0-experimental-9cdf8a99e-20221018',
'react-dom': '0.0.0-experimental-9cdf8a99e-20221018',
},
skipStart: true,
})
})
Expand Down
4 changes: 4 additions & 0 deletions test/development/acceptance-app/ReactRefreshModule.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@ describe('ReactRefreshModule app', () => {
beforeAll(async () => {
next = await createNext({
files: new FileRef(path.join(__dirname, 'fixtures', 'default-template')),
dependencies: {
react: '0.0.0-experimental-9cdf8a99e-20221018',
'react-dom': '0.0.0-experimental-9cdf8a99e-20221018',
},
skipStart: true,
})
})
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ describe('ReactRefreshRegression app', () => {
'styled-components': '5.1.0',
'@next/mdx': 'canary',
'@mdx-js/loader': '0.18.0',
react: '0.0.0-experimental-9cdf8a99e-20221018',
'react-dom': '0.0.0-experimental-9cdf8a99e-20221018',
},
})
})
Expand Down
4 changes: 4 additions & 0 deletions test/development/acceptance-app/ReactRefreshRequire.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@ describe('ReactRefreshRequire app', () => {
beforeAll(async () => {
next = await createNext({
files: new FileRef(path.join(__dirname, 'fixtures', 'default-template')),
dependencies: {
react: '0.0.0-experimental-9cdf8a99e-20221018',
'react-dom': '0.0.0-experimental-9cdf8a99e-20221018',
},
skipStart: true,
})
})
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP

exports[`ReactRefreshLogBox app Module not found 1`] = `
"./index.js:1:0
Module not found: Can't resolve 'b'
> 1 | import Comp from 'b'
2 | export default function Oops() {
3 | return (
4 | <div>

Import trace for requested module:
./app/page.js

https://nextjs.org/docs/messages/module-not-found"
`;

exports[`ReactRefreshLogBox app Module not found empty import trace 1`] = `
"./app/page.js:2:6
Module not found: Can't resolve 'b'
1 | 'use client'
> 2 | import Comp from 'b'
| ^
3 | export default function Oops() {
4 | return (
5 | <div>

https://nextjs.org/docs/messages/module-not-found"
`;

exports[`ReactRefreshLogBox app Module not found missing global CSS 1`] = `
"./app/page.js:2:10
Module not found: Can't resolve './non-existent.css'
1 | 'use client'
> 2 | import './non-existent.css'
| ^
3 | export default function Page(props) {
4 | return <p>index page</p>
5 | }

https://nextjs.org/docs/messages/module-not-found"
`;

exports[`ReactRefreshLogBox app Node.js builtins 1`] = `
"./node_modules/my-package/index.js:2:0
Module not found: Can't resolve 'dns'

Import trace for requested module:
./index.js
./app/page.js

https://nextjs.org/docs/messages/module-not-found"
`;