Bug: Update objectFit style as attribute on <Image /> #41787
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the working example of how to implement background images using next/image, I found that the current way this is written (the `object-fit` css property within a style tag) does not actually apply the style (on version ^12.3.1). So I thought it may be worth making a note either to the existing style as I listed above, or the inverse— where a note is left to explain objectFit must be written as its own attribute on the `<Image />` component rather than within the style tag in order to apply correctly. Thanks!
yellosun
requested review from
timneutkens,
ijjk,
shuding and
styfle
as code owners
|
Thanks, but the current code is actually correct as Next.js 13 now does not have the |
11 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
As the working example of how to implement background images using next/image, I found that the current way this is written (the
object-fitcss property within a style tag) does not actually apply the style (on version ^12.3.1). So I thought it may be worth making a note either to the existing style as I listed above, or the inverse— where a note is left to explain objectFit must be written as its own attribute on the<Image />component rather than within the style tag in order to apply correctly. Thanks!