Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Next/Script documentation beforeInteractive inconsistency #44898

Merged
merged 3 commits into from
Jan 16, 2023
Merged

Next/Script documentation beforeInteractive inconsistency #44898

merged 3 commits into from
Jan 16, 2023

Conversation

rortan134
Copy link
Contributor

Closes #43566

Following linter syntax & error documentation

image
image

@ijjk ijjk added the create-next-app Related to our CLI tool for quickly starting a new Next.js application. label Jan 16, 2023
ijjk
ijjk approved these changes Jan 16, 2023
View reviewed changes
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This update does look correct as beforeInteractive scripts are expected to be placed in _document now, thanks for the PR!

@ijjk ijjk merged commit 196957f into vercel:canary Jan 16, 2023
@rortan134 rortan134 deleted the nextscript-beforeinteractive-docs-fix branch January 16, 2023 02:17
@cmbritten
Copy link
Contributor

cmbritten commented Jan 16, 2023 •
edited

Thanks for the PR and for closing the issue! @rortan134

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

@shuding shuding Awaiting requested review from shuding

@styfle styfle Awaiting requested review from styfle

@huozhi huozhi Awaiting requested review from huozhi

@padmaia padmaia Awaiting requested review from padmaia

@leerob leerob Awaiting requested review from leerob

@balazsorban44 balazsorban44 Awaiting requested review from balazsorban44

Assignees
No one assigned
Labels
create-next-app Related to our CLI tool for quickly starting a new Next.js application.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs: Inconsistency regarding where to put <Script> components that have the beforeInteractive strategy.
3 participants
@rortan134 @cmbritten @ijjk