Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken argument for rewrites on link reference docs #45073

Merged
merged 2 commits into from
Jan 20, 2023

Conversation

guilhermefront
Copy link
Contributor

Fixes #45072

Rewrites don't accept relative paths anymore, we have to pass an absolute URL (see https://nextjs.org/docs/messages/middleware-relative-urls)

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have a helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • e2e tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have a helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running pnpm build && pnpm lint
  • The "examples guidelines" are followed from our contributing doc

Rewrites don't accept relative paths anymore, we have to pass an absolute url (see https://nextjs.org/docs/messages/middleware-relative-urls)
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@kodiakhq kodiakhq bot merged commit 55f3a6d into vercel:canary Jan 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: broken example for middleware rewrites on link reference
2 participants