Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create-next-app: warn if project dir isn't empty before prompts #45195

Merged
merged 1 commit into from Jan 23, 2023
Merged

create-next-app: warn if project dir isn't empty before prompts #45195

merged 1 commit into from Jan 23, 2023

Conversation

MaxLeiter
Copy link
Member

@MaxLeiter MaxLeiter commented Jan 23, 2023 •
edited

Checks if the dir is empty before prompting the user rather than just after trying to create it. Has the benefit of not having a stacktrace if we catch it the first time because we don’t throw an error in createApp

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
    • I talked to JJ
  • Related issues linked using fixes #number
  • e2e tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have a helpful link attached, see contributing.md

@ijjk ijjk added the create-next-app Related to our CLI tool for quickly starting a new Next.js application. label Jan 23, 2023
ijjk
ijjk approved these changes Jan 23, 2023
View reviewed changes
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ijjk ijjk merged commit a3b89a5 into vercel:canary Jan 23, 2023
@MaxLeiter MaxLeiter deleted the maxleiter/earlier-warn-nonempty branch January 23, 2023 20:17
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

@shuding shuding Awaiting requested review from shuding

@huozhi huozhi Awaiting requested review from huozhi

@feedthejim feedthejim Awaiting requested review from feedthejim

Assignees
No one assigned
Labels
create-next-app Related to our CLI tool for quickly starting a new Next.js application.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MaxLeiter @ijjk