Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update isStale checking for fetch cache (#46331 #46331

Merged
merged 2 commits into from
Feb 24, 2023
Merged

Update isStale checking for fetch cache (#46331 #46331

merged 2 commits into from
Feb 24, 2023

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Feb 24, 2023

This ensures we set lastModified when pulling from upstream cache instead of using isStale on the cache entry since once it's stored to the memory cache the isStale field would never be updated.

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Feb 24, 2023
lubakravche
lubakravche approved these changes Feb 24, 2023
View reviewed changes
Copy link
Collaborator

@lubakravche lubakravche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@ijjk ijjk changed the title Update isStale checking for fetch cache Update isStale checking for fetch cache (#46331 Feb 24, 2023
@ijjk ijjk merged commit 5c6d070 into vercel:canary Feb 24, 2023
@ijjk ijjk deleted the update/fetch-cache branch February 24, 2023 00:57
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lubakravche lubakravche lubakravche approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

@shuding shuding Awaiting requested review from shuding shuding is a code owner

@huozhi huozhi Awaiting requested review from huozhi huozhi is a code owner

@feedthejim feedthejim Awaiting requested review from feedthejim feedthejim is a code owner

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ijjk @lubakravche