Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure hashchanges get triggered #4676

Merged
merged 3 commits into from
Jun 28, 2018

Conversation

timneutkens
Copy link
Member

When clicking a next/link with a hash (#something) multiple times, it wouldn't keep the scrolling behavior browsers have. This makes sure we correctly trigger it.

@timneutkens
Copy link
Member Author

Also found an issue when linking to # it wouldn't scroll to top when clicked, which is the default browser behavior

@timneutkens timneutkens merged commit 57d8af8 into vercel:canary Jun 28, 2018
@timneutkens timneutkens deleted the fix/hashchange-same-hash branch June 28, 2018 18:56
@timneutkens
Copy link
Member Author

Merged as @rauchg reviewed.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant