Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update with-redux-observable example #4818

Merged
merged 1 commit into from
Jul 21, 2018
Merged

update with-redux-observable example #4818

merged 1 commit into from
Jul 21, 2018

Conversation

Tomekmularczyk
Copy link
Contributor

@Tomekmularczyk Tomekmularczyk commented Jul 21, 2018 •
edited
Loading

Changes:

  • update rxjs5 => rxjs6 and fix breaking changes,
  • update redux-observable to v1 and fix breaking changes
  • use custom-App and to integrate redux in a single place
  • replace universal-rxjs-request with rxjs6 compatible universal-rxjs-ajax
  • remove unnecessary superagent and redux-thunk dependencies

timneutkens
timneutkens approved these changes Jul 21, 2018
View reviewed changes
Copy link
Member

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@timneutkens timneutkens merged commit 53853d3 into vercel:canary Jul 21, 2018
@kalabro kalabro mentioned this pull request Aug 5, 2018
Merged
timneutkens pushed a commit that referenced this pull request Aug 5, 2018
@timneutkens
Fixed server status message in with-redux-observable-example. (#4900)
05b6891 
**Changes:**
- Fixed "was character fetched on server" message by properly passing `isServer`.
- Stop fetching if there was an error (currently it keeps sending requests to the same endpoint every 3 sec)

**Related:**
- #4818
- #4724
@lock lock bot locked as resolved and limited conversation to collaborators Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Tomekmularczyk @timneutkens