Missing babel configuration in sw-precache example #4856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Missing configuration causes this example to break.
jmaguirrei
changed the title
timneutkens
reviewed
Jul 27, 2018
examples/with-sw-precache/.babelrc
Outdated
| { | ||
|
|
||
| "presets": [ | ||
| [ "next/babel", { "preset-env": { "modules": "commonjs" }} ] |
There was a problem hiding this comment.
This should never be done, only in the test environment.
timneutkens
reviewed
Jul 27, 2018
| @@ -10,5 +10,8 @@ | |||
| "react": "^16.0.0", | |||
| "react-dom": "^16.0.0", | |||
| "sw-precache-webpack-plugin": "^0.11.3" | |||
| }, | |||
| "devDependencies": { | |||
| "@babel/preset-stage-0": "^7.0.0-beta.42" | |||
There was a problem hiding this comment.
This doesn't add anything to the example right 🤔
jmaguirrei
commented
Jul 27, 2018
timneutkens
reviewed
Jul 27, 2018
| @@ -0,0 +1,19 @@ | |||
| { | |||
There was a problem hiding this comment.
There's no "test" script in this example so the babelrc shouldn't be here right
There was a problem hiding this comment.
Yes, you are right, I corrected it.
timneutkens
approved these changes
Jul 27, 2018
|
Thanks! |
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing configuration in package.json and .babelrc causes this example to be broken after installing and running the example.