Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: TS plugin showing warning for global-error file's reset prop #48756

Merged
merged 1 commit into from Apr 23, 2023

Conversation

sreetamdas
Copy link
Contributor

The TS plugin incorrectly gives a warning for the reset prop in the global-error.tsx file. This was previously reported and fixed for the error.tsx file.


You can see a reproduction on CodeSandboxglobal-error.tsx's reset prop has the following warning:

Props must be serializable for components in the "use client" entry file, "reset" is invalid. ts(71007)

I haven't filed an issue for this yet since this was a simple enough fix, but happy to create one if needed :)

Copy link
Member

@shuding shuding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx!

@kodiakhq kodiakhq bot merged commit 0670023 into vercel:canary Apr 23, 2023
92 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants