Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: disable client cache flaky test #48890

Merged
merged 3 commits into from Apr 26, 2023
Merged

test: disable client cache flaky test #48890

merged 3 commits into from Apr 26, 2023

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Apr 26, 2023

@ijjk ijjk added area: tests created-by: Next.js team PRs by the Next.js team labels Apr 26, 2023
@ijjk
Copy link
Member

ijjk commented Apr 26, 2023

Failing test suites

Commit: 37536d8

pnpm testheadless test/development/acceptance/ReactRefreshLogBox-builtins.test.ts

  • ReactRefreshLogBox default > Module not found (missing global CSS)
Expand output

● ReactRefreshLogBox default › Module not found (missing global CSS)

expect(received).toContain(expected) // indexOf

Expected substring: "index page"
Received string:    "<head><meta charset=\"utf-8\"><meta name=\"viewport\" content=\"width=device-width\"><meta name=\"next-head-count\" content=\"2\"><noscript data-n-css=\"\"></noscript><script defer=\"\" nomodule=\"\" src=\"/_next/static/chunks/polyfills.js?ts=1682543452956\"></script><script src=\"/_next/static/chunks/fallback/webpack.js?ts=1682543452956\" defer=\"\"></script><script src=\"/_next/static/chunks/fallback/main.js?ts=1682543452956\" defer=\"\"></script><script src=\"/_next/static/chunks/fallback/pages/_app.js?ts=1682543452956\" defer=\"\"></script><script src=\"/_next/static/chunks/fallback/pages/_error.js?ts=1682543452956\" defer=\"\"></script><noscript id=\"__next_css__DO_NOT_USE__\"></noscript></head><body style=\"overflow: hidden;\"><div id=\"__next\"></div><script src=\"/_next/static/chunks/fallback/react-refresh.js?ts=1682543452956\"></script><script id=\"__NEXT_DATA__\" type=\"application/json\">{\"props\":{\"pageProps\":{\"statusCode\":500}},\"page\":\"/_error\",\"query\":{},\"buildId\":\"development\",\"isFallback\":false,\"err\":{\"name\":\"Error\",\"source\":\"server\",\"message\":\"Module not found: Can't resolve './non-existent.css'\\n  1 | \\n\\u003e 2 |         import './non-existent.css'\\n    |        ^\\n  3 | \\n  4 |         export default function App({ Component, pageProps }) {\\n  5 |           return \\u003cComponent {...pageProps} /\\u003e\\n\\nhttps://nextjs.org/docs/messages/module-not-found\\n\",\"stack\":\"Error: \\u001b[31m\\u001b[1mModule not found\\u001b[22m\\u001b[39m: Can't resolve '\\u001b[32m./non-existent.css\\u001b[39m'\\n\\u001b[0m \\u001b[90m 1 | \\u001b[39m\\u001b[0m\\n\\u001b[0m\\u001b[31m\\u001b[1m\\u003e\\u001b[22m\\u001b[39m\\u001b[90m 2 | \\u001b[39m        \\u001b[36mimport\\u001b[39m \\u001b[32m'./non-existent.css'\\u001b[39m\\u001b[0m\\n\\u001b[0m \\u001b[90m   | \\u001b[39m       \\u001b[31m\\u001b[1m^\\u001b[22m\\u001b[39m\\u001b[0m\\n\\u001b[0m \\u001b[90m 3 | \\u001b[39m\\u001b[0m\\n\\u001b[0m \\u001b[90m 4 | \\u001b[39m        \\u001b[36mexport\\u001b[39m \\u001b[36mdefault\\u001b[39m \\u001b[36mfunction\\u001b[39m \\u001b[33mApp\\u001b[39m({ \\u001b[33mComponent\\u001b[39m\\u001b[33m,\\u001b[39m pageProps }) {\\u001b[0m\\n\\u001b[0m \\u001b[90m 5 | \\u001b[39m          \\u001b[36mreturn\\u001b[39m \\u001b[33m\\u003c\\u001b[39m\\u001b[33mComponent\\u001b[39m {\\u001b[33m...\\u001b[39mpageProps} \\u001b[33m/\\u001b[39m\\u001b[33m\\u003e\\u001b[39m\\u001b[0m\\n\\nhttps://nextjs.org/docs/messages/module-not-found\\n\\n    at getNotFoundError (/tmp/next-install-837cf1421395afecf34340fbdd82d6ce30321b6cc65f80b9ca6c6df0f3b745fd/node_modules/.pnpm/file+..+next-repo-c8199cd56ced820bbdc8edd9fe81c1e6_zzmzwjxk2j2frnfo4xwtgvks3m/node_modules/next/dist/build/webpack/plugins/wellknown-errors-plugin/parseNotFoundError.js:124:16)\\n    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)\\n    at async getModuleBuildError (/tmp/next-install-837cf1421395afecf34340fbdd82d6ce30321b6cc65f80b9ca6c6df0f3b745fd/node_modules/.pnpm/file+..+next-repo-c8199cd56ced820bbdc8edd9fe81c1e6_zzmzwjxk2j2frnfo4xwtgvks3m/node_modules/next/dist/build/webpack/plugins/wellknown-errors-plugin/webpackModuleError.js:102:27)\\n    at async /tmp/next-install-837cf1421395afecf34340fbdd82d6ce30321b6cc65f80b9ca6c6df0f3b745fd/node_modules/.pnpm/file+..+next-repo-c8199cd56ced820bbdc8edd9fe81c1e6_zzmzwjxk2j2frnfo4xwtgvks3m/node_modules/next/dist/build/webpack/plugins/wellknown-errors-plugin/index.js:21:49\\n    at async Promise.all (index 0)\\n    at async /tmp/next-install-837cf1421395afecf34340fbdd82d6ce30321b6cc65f80b9ca6c6df0f3b745fd/node_modules/.pnpm/file+..+next-repo-c8199cd56ced820bbdc8edd9fe81c1e6_zzmzwjxk2j2frnfo4xwtgvks3m/node_modules/next/dist/build/webpack/plugins/wellknown-errors-plugin/index.js:19:21\"},\"gip\":true,\"scriptLoader\":[]}</script><div id=\"__next-build-watcher\" style=\"position: fixed; bottom: 10px; right: 20px; width: 0px; height: 0px; z-index: 99999;\"></div><next-route-announcer><p aria-live=\"assertive\" id=\"__next-route-announcer__\" role=\"alert\" style=\"border: 0px; clip: rect(0px, 0px, 0px, 0px); height: 1px; margin: -1px; overflow: hidden; padding: 0px; position: absolute; top: 0px; width: 1px; white-space: nowrap; overflow-wrap: normal;\"></p></next-route-announcer><nextjs-portal></nextjs-portal></body>"

  144 |       expect(
  145 |         await session.evaluate(() => document.documentElement.innerHTML)
> 146 |       ).toContain('index page')
      |         ^
  147 |
  148 |       await cleanup()
  149 |     })

  at Object.<anonymous> (development/acceptance/ReactRefreshLogBox-builtins.test.ts:146:9)

Read more about building and testing Next.js in contributing.md.

@kodiakhq kodiakhq bot merged commit 7c1ee05 into vercel:canary Apr 26, 2023
91 of 93 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@feedthejim feedthejim feedthejim approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

@ijjk ijjk Awaiting requested review from ijjk ijjk is a code owner

@shuding shuding Awaiting requested review from shuding shuding is a code owner

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@huozhi @ijjk @feedthejim