Fix scroll when loading.js/ts is used #48986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timneutkens
requested review from
ijjk,
shuding,
huozhi and
feedthejim
as code owners
ijjk
added
area: tests
created-by: Next.js team
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
ijjk
approved these changes
Apr 29, 2023
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Whenever you navigated and a page suspended through
loadingor an error happened caught byerrorin the first level of segments (e.g./dashboardbut not/dashboard/settings) scroll would not be applied. This happened because the focus and scroll handling component is rendered as part ofInnerLayoutRouterand the Suspense / Error boundary was rendered aroundInnerLayoutRouter. This behavior is incorrect as we still want to immediately scroll to the place where the loading is rendered.This PR fixes the behavior by allowing the scroll to apply to loading / error too.
How?
Moved the scrolling component around the loading/error/innerlayout boundary and added tests.