Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

type: update React.CSSProperties type to Record #49186

Merged
merged 12 commits into from May 9, 2023
Merged

type: update React.CSSProperties type to Record #49186

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
c0e04f7
type: update React.CSSProperties type to Record
li-jia-nan May 4, 2023
7f8d9ac
Merge branch 'canary' into type
li-jia-nan May 4, 2023
6c763cb
Update packages/next/src/pages/_error.tsx
li-jia-nan May 4, 2023
9e69880
Update packages/next/src/client/components/error.tsx
li-jia-nan May 4, 2023
9515a10
Merge branch 'canary' into type
li-jia-nan May 4, 2023
90c972c
Merge branch 'canary' into type
li-jia-nan May 4, 2023
2051088
Merge branch 'canary' into type
li-jia-nan May 4, 2023
00bacdf
Merge branch 'canary' into type
li-jia-nan May 4, 2023
dc81993
Merge branch 'canary' into type
li-jia-nan May 6, 2023
8bb3a45
Merge branch 'canary' into type
li-jia-nan May 7, 2023
2681b17
Merge branch 'canary' into type
li-jia-nan May 8, 2023
a319a7c
Merge branch 'canary' into type
li-jia-nan May 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/next/src/client/components/error.tsx
View file
Open in desktop
@@ -1,6 +1,6 @@
import React from 'react'

const styles: { [k: string]: React.CSSProperties } = {
const styles: Record<string, React.CSSProperties> = {
error: {
// https://github.com/sindresorhus/modern-normalize/blob/main/modern-normalize.css#L38-L52
fontFamily:
Expand Down
2 changes: 1 addition & 1 deletion packages/next/src/pages/_error.tsx
View file
Open in desktop
Expand Up @@ -24,7 +24,7 @@ function _getInitialProps({
return { statusCode }
}

const styles: { [k: string]: React.CSSProperties } = {
const styles: Record<string, React.CSSProperties> = {
error: {
// https://github.com/sindresorhus/modern-normalize/blob/main/modern-normalize.css#L38-L52
fontFamily:
Expand Down