Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rimraf for cross platform assets removal #49522

Closed
wants to merge 2 commits into from

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented May 9, 2023

We've already switched to rimraf in #44011 for windows compatibility, this PR changed the left packages clean commands to use rimraf

Closes #42433

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels May 9, 2023
@ijjk
Copy link
Member

ijjk commented May 9, 2023

Failing test suites

Commit: 6c1adf5

pnpm testheadless test/e2e/middleware-dynamic-basepath-matcher/test/index.test.ts

  • Middleware custom matchers basePath > should match query path
Expand output

● Middleware custom matchers basePath › should match query path

expect(received).toBe(expected) // Object.is equality

Expected: "another-page"
Received: "random"

  51 |     await browser.elementById('linkelement').click()
  52 |     const anotherPagePath = await browser.elementById('router-path').text()
> 53 |     expect(anotherPagePath).toBe('another-page')
     |                             ^
  54 |   })
  55 | })
  56 |

  at Object.<anonymous> (e2e/middleware-dynamic-basepath-matcher/test/index.test.ts:53:29)

Read more about building and testing Next.js in contributing.md.

@kodiakhq kodiakhq bot closed this in #49529 May 10, 2023
kodiakhq bot pushed a commit that referenced this pull request May 10, 2023
@huozhi huozhi deleted the use-rimraf branch May 17, 2023 09:51
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'rm' command alternative to support build on a Windows & Linux OS machine
3 participants