Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: metadataBase is ignored when openGraph.images has a URL #49889

Closed
wants to merge 1 commit into from
Closed

fix: metadataBase is ignored when openGraph.images has a URL #49889

wants to merge 1 commit into from

Conversation

renomureza
Copy link

@renomureza renomureza commented May 17, 2023 •
edited

What?

metadataBase is ignored when openGraph.images has a URL.

Why?

The getSocialImageFallbackMetadataBase function ignores the given URL and returns fallbackMetadata.

How?

This PR makes the getSocialImageFallbackMetadataBase function return the given URL if provided.

Fixes #49807

@huozhi huozhi mentioned this pull request May 17, 2023
Merged
@kodiakhq kodiakhq bot closed this in #49924 May 17, 2023
kodiakhq bot pushed a commit that referenced this pull request May 17, 2023
@huozhi
Fix port value for metadataBase (#49924)
7641278 
metadataBase is using `process.env.PORT` to construct a host when there's no `metadataBase` specified in layout. Dev server needs to pass down the PORT env from the parent prcoess.

Fixes #49807
Fixes #49859
Closes #49889
@renomureza renomureza deleted the metadata-ogimage-url branch May 17, 2023 13:40
hydRAnger pushed a commit to hydRAnger/next.js that referenced this pull request Jun 12, 2023
@huozhi @hydRAnger
Fix port value for metadataBase (vercel#49924)
68fa26d 
metadataBase is using `process.env.PORT` to construct a host when there's no `metadataBase` specified in layout. Dev server needs to pass down the PORT env from the parent prcoess.

Fixes vercel#49807
Fixes vercel#49859
Closes vercel#49889
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

@ijjk ijjk Awaiting requested review from ijjk ijjk is a code owner

@shuding shuding Awaiting requested review from shuding shuding is a code owner

@huozhi huozhi Awaiting requested review from huozhi huozhi is a code owner

@feedthejim feedthejim Awaiting requested review from feedthejim feedthejim is a code owner

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

metadataBase is ignored when openGraph.images has a relative path
2 participants
@renomureza @ijjk