Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix required check job #50620

Merged
merged 2 commits into from
Jun 1, 2023
Merged

Fix required check job #50620

merged 2 commits into from
Jun 1, 2023

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Jun 1, 2023

@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team. label Jun 1, 2023
@ijjk ijjk marked this pull request as ready for review June 1, 2023 01:38
@ijjk ijjk requested a review from a team as a code owner June 1, 2023 01:38
@ijjk ijjk merged commit fa076a3 into vercel:canary Jun 1, 2023
- run: exit 1
if: failure()
if: ${{ always() && contains(needs.*.result, 'failure') }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice if it works!

I used a slightly more verbose solution here:

vercel/vercel#10048

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants