Add with-context-api example #5154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timneutkens
reviewed
Sep 13, 2018
| "start": "next start" | ||
| }, | ||
| "dependencies": { | ||
| "next": "latest", |
There was a problem hiding this comment.
Let's use canary here, as it doesn't work on 6.x
There was a problem hiding this comment.
That should be "next": "7.0.0-canary.16" ?
Sorry, my first PR 😄
There was a problem hiding this comment.
"next": "^7.0.0-canary.16",
There was a problem hiding this comment.
You should be good with yarn add next@canary 👍
klujanrosas
reviewed
Sep 13, 2018
| @@ -0,0 +1,19 @@ | |||
| import App, { Container } from 'next/app' | |||
| /* First we import our provider */ | |||
| import NoteProvider from '../components/CounterProvider' | |||
There was a problem hiding this comment.
@wesbos example used NoteProvider
But this here should be called CounterProvider now, right?
There was a problem hiding this comment.
YEs - sorry I ripped this out of another app :)
There was a problem hiding this comment.
Yes. it should be CounterProvider. I based on @wesbos example and forget to change that import
timneutkens
approved these changes
Sep 14, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #4182