Improvements to on-demand-entries #5176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timneutkens
commented
Sep 16, 2018
| const hasNoModuleFoundError = /ENOENT/.test(e.message) || /Module not found/.test(e.message) | ||
| if (!hasNoModuleFoundError) return false | ||
| // compilation.entrypoints is a Map object, so iterating over it 0 is the key and 1 is the value | ||
| for (const [, entrypoint] of compilation.entrypoints.entries()) { |
There was a problem hiding this comment.
The main change in this PR is that we're no longer calling doneCallbacks on entries, because this leads to timing issues. Instead we use webpack's compilation.entrypoints as the source of truth of what's compiled (which is logical, as it holds exactly what's compiled in this compilation run).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First wave of changes. Just landing this first so that there is a base to build on.