-
Notifications
You must be signed in to change notification settings - Fork 26.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add note about standalone mode not working for app router #51828
Conversation
We are using standalone mode with appDirectory without any issues on 2 prod projects, as far as I know. The only issue we have is the server dying after some time due to OOM issues, but that's I think unrelated to standalone: #45508 But please correct me if I am wrong and we should get rid of output: standalone |
It seems that this isn't just a problem with appDir, my project uses pageDir, but it's also has this problem |
Yeah, I know. Just wanted to say that we use standalone mode without any problems with appDirectory. The OOM/crashes are not related to this issue. |
Sorry if this is actually no longer the case, and standalone mode should work fine with the App router. I just ran into this when trying to use standalone mode for this template https://github.com/medusajs/nextjs-starter-medusa. I also tried to install So without standalone mode it works fine, but when I turn it on, I get this build error
|
Well I am just unsure, you get some weird errors on start but seems like it works fine in prod, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking because I'd like to get some clarity here first before this gets merged.
@bjornarhagen if you are using the I added App Router support for |
@DuCanhGH I see, must be something https://github.com/medusajs/nextjs-starter-medusa is doing that is causing the standalone build to fail then. Setting Thank you so much! 😄 |
Note that the experimental flag is not needed with v13.4+. |
…re is no `app/` page (#51993) ### What? This PR fixes build crashing when `output: 'standalone'` and `experimental.appDir` is enabled but there is no app pages. ### How? It does that by checking whether `.next/server/app` exists before copying the folder to `.next/standalone/...` Closes #51828 Fixes #44442 Fixes #44120
No description provided.