New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure react always ends up in the commons bundle #5192

Merged

timneutkens merged 1 commit into vercel:canary from timneutkens:fix/react-dom-react-commons

Sep 17, 2018

Member

timneutkens commented Sep 17, 2018 •

edited

Fixes an edge case where some library imports react-dom by itself, like react-spring.


          Make sure react always ends up in the commons bundle

a1b0efd

shuding approved these changes

View reviewed changes

timneutkens merged commit 10a9178 into vercel:canary

timneutkens deleted the fix/react-dom-react-commons branch

September 17, 2018 13:57

lock bot locked as resolved and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.