Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build-native turbo config #53380

Merged
merged 2 commits into from
Jul 31, 2023
Merged

Fix build-native turbo config #53380

merged 2 commits into from
Jul 31, 2023

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Jul 31, 2023 •
edited by styfle

The turbo cache is currently not being invalidated for our build-native jobs when the root Cargo.lock is changed so #53308 never actually got re-built/applied in CI and tests are unexpectedly passing.

x-ref: slack thread

@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team label Jul 31, 2023
@ijjk ijjk requested a review from styfle July 31, 2023 13:32
@ijjk ijjk mentioned this pull request Jul 31, 2023
Merged
ijjk added a commit that referenced this pull request Jul 31, 2023
@ijjk
Revert "Update swc_core to v0.79.33 (#53308)" (#53381)
e1a10c6 
This reverts commit da043b5.

x-ref: #53380
styfle
styfle approved these changes Jul 31, 2023
View reviewed changes
Copy link
Member

@styfle styfle left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Looks like I missed these in a previous PR:

@kodiakhq kodiakhq bot merged commit 0c70b9f into vercel:canary Jul 31, 2023
49 checks passed
@ijjk ijjk deleted the fix/build-native-turbo-config branch July 31, 2023 14:01
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@styfle styfle styfle approved these changes

@feedthejim feedthejim feedthejim approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

@shuding shuding Awaiting requested review from shuding shuding is a code owner

@huozhi huozhi Awaiting requested review from huozhi huozhi is a code owner

@ztanner ztanner Awaiting requested review from ztanner ztanner is a code owner

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team locked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ijjk @styfle @feedthejim