Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tracing in require-hook #53642

Merged
merged 1 commit into from
Aug 6, 2023
Merged

Fix tracing in require-hook #53642

merged 1 commit into from
Aug 6, 2023

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Aug 6, 2023

This ensures the resolve calls for styled-jsx are done in the correct context so that tracing can include the correct symlinks/package.json files.

x-ref: slack thread

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Aug 6, 2023
@ijjk ijjk marked this pull request as ready for review August 6, 2023 20:04
@kodiakhq kodiakhq bot merged commit f114060 into vercel:canary Aug 6, 2023
50 checks passed
@ijjk ijjk deleted the fix/styled-jsx-trace branch August 6, 2023 20:25
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ztanner ztanner ztanner approved these changes

@huozhi huozhi huozhi approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

@shuding shuding Awaiting requested review from shuding shuding is a code owner

@feedthejim feedthejim Awaiting requested review from feedthejim feedthejim is a code owner

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team locked type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ijjk @ztanner @huozhi