-
Notifications
You must be signed in to change notification settings - Fork 26.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Cannot redefine property: $$id
error
#54654
Conversation
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Orca Security Scan Summary
Status | Check | Issues by priority | |
---|---|---|---|
Passed | Secrets | 0 0 0 0 | View in Orca |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, could you get a minimal reproduction of this issue so we can have a test case for it?
@shuding - I hope this one is quite self-explanatory. I think the vercel team has to decide if those action properties should be considered reserved/read only or if other libraries can use the same properties. Or else just clarify the way this is supposed to work, generally. I arrived at this issue because tRPC is in some cases providing its own ID, leading to |
Might be related to TheEdoRan/next-safe-action#56 |
Fixes: #54655
action: any
could already be defined, leading to acannot redefine error
on new builds, affectingserver actions
Introduced by here:
https://github.com/vercel/next.js/pull/54232/files#diff-95a0d700e8c22a337ac8800d4ddf80f44c6369aa2e6acf5bd2b71632f7471c68R35-R48