Redesign nextjs logging #54713
Merged
Redesign nextjs logging #54713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijjk
added
area: tests
Turbopack
![orca-security-us[bot]](https://avatars.githubusercontent.com/in/276250?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Secrets |  0  1  0  0 |
View in Orca |
This comment was marked as outdated.
This comment was marked as outdated.
Tests Passed |
huozhi
requested review from
feedthejim,
ztanner and
wyattjoh
as code owners
|
Notifying the following users due to files changed in this PR based on this repo's notify modifiers: @timneutkens, @ijjk, @shuding, @styfle: |
timneutkens
reviewed
Sep 4, 2023
timneutkens
reviewed
Sep 4, 2023
timneutkens
reviewed
Sep 4, 2023
timneutkens
reviewed
Sep 4, 2023
timneutkens
reviewed
Sep 4, 2023
timneutkens
reviewed
Sep 4, 2023
timneutkens
reviewed
Sep 4, 2023
timneutkens
reviewed
Sep 4, 2023
ijjk
added a commit
that referenced
this pull request
Sep 5, 2023
Looks liket his has been broken since #54713 due to the text it watches for being changed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current logging styles has been existed for a while, this PR gives a fresh impression for the logging output from Next.js.
We want to achieve few new goals that makes the output clean, modernized, sweet 🍫 .
Few goals are addressed with this redesign:
Refresh Impression & Simplification
The new design of logging is much more information centralized and streamlined.
readymessage at the begining when compilers are bootstrapped.compiledevent with green check mark indicating succesful compilation, this will merge the unclearcompilingevent which shows(client and server)before, now tell you the route compilation info in one line.hello world app
next devAfter vs Before
next buildAfter vs Before
error status
After vs Before
Streamlization
If you have customized envs and experiments Next.js will give the brief in the early summary about your network information, env vars, and enabled experimental features
Polish
fetching logging structure
After vs Before
Dedupe Duplicates
The logging is moved from
@next/envtonextitself,@next/envwill only notify the invoker that the env is reloaded. Then the duplicated logs for the env reloading cases can be avoid.After vs Before
Different indicators
Use unicode text icons for different situation: