Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turbopack + app router: always use externals for predefined packages #56440

Merged
merged 20 commits into from Oct 6, 2023
Merged

Turbopack + app router: always use externals for predefined packages #56440

merged 20 commits into from Oct 6, 2023

Commits on Oct 4, 2023

  1. Add test for using external node_modules for pages 

    This adds a test that asserts that, without additional configuration like `experimental.bundlePagesExternals`, Next.js does not bundle `node_modules` for pages.
    @wbinnssmith
    wbinnssmith committed Oct 4, 2023
    Copy the full SHA
    6c8e952 View commit details
    Browse the repository at this point in the history

  2. fixup! Add test for using external node_modules for pages

    @wbinnssmith
    wbinnssmith committed Oct 4, 2023
    Copy the full SHA
    7b13a60 View commit details
    Browse the repository at this point in the history

  3. fixup! Add test for using external node_modules for pages

    @wbinnssmith
    wbinnssmith committed Oct 4, 2023
    Copy the full SHA
    ab6e12f View commit details
    Browse the repository at this point in the history

  4. fixup! Add test for using external node_modules for pages

    @wbinnssmith
    wbinnssmith committed Oct 4, 2023
    Copy the full SHA
    6a4acc7 View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'origin/canary' into wbinnssmith/pages-e… 

    …xternal
    @wbinnssmith
    wbinnssmith committed Oct 4, 2023
    Copy the full SHA
    ec9ab85 View commit details
    Browse the repository at this point in the history

  6. Turbopack + app router: always use externals for predefined packages 

    This applies the predefined list of packages in server-external-packages.json as always external when used by app router in Turbopack

Test Plan: Added integration tests
    @wbinnssmith
    wbinnssmith committed Oct 4, 2023
    Copy the full SHA
    3485e0a View commit details
    Browse the repository at this point in the history

  7. fixup! Turbopack + app router: always use externals for predefined pa… 

    …ckages
    @wbinnssmith
    wbinnssmith committed Oct 4, 2023
    Copy the full SHA
    60fd82a View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2023

  1. fixup! Turbopack + app router: always use externals for predefined pa… 

    …ckages
    @wbinnssmith
    wbinnssmith committed Oct 5, 2023
    Copy the full SHA
    5b0dbd2 View commit details
    Browse the repository at this point in the history

  2. fixup! Turbopack + app router: always use externals for predefined pa… 

    …ckages
    @wbinnssmith
    wbinnssmith committed Oct 5, 2023
    Copy the full SHA
    c149b0c View commit details
    Browse the repository at this point in the history

  3. fixup! Turbopack + app router: always use externals for predefined pa… 

    …ckages
    @wbinnssmith
    wbinnssmith committed Oct 5, 2023
    Copy the full SHA
    cd83ef3 View commit details
    Browse the repository at this point in the history

  4. fixup! Add test for using external node_modules for pages

    @wbinnssmith
    wbinnssmith committed Oct 5, 2023
    Copy the full SHA
    6a23aa6 View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'origin/canary' into wbinnssmith/pages-e… 

    …xternal
    @wbinnssmith
    wbinnssmith committed Oct 5, 2023
    Copy the full SHA
    35b00e1 View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch 'origin/wbinnssmith/pages-external' into… 

    … wbinnssmith/app-external
    @wbinnssmith
    wbinnssmith committed Oct 5, 2023
    Copy the full SHA
    6495fb5 View commit details
    Browse the repository at this point in the history

  7. fixup! Turbopack + app router: always use externals for predefined pa… 

    …ckages
    @wbinnssmith
    wbinnssmith committed Oct 5, 2023
    Copy the full SHA
    4f13a77 View commit details
    Browse the repository at this point in the history

  8. fixup! Turbopack + app router: always use externals for predefined pa… 

    …ckages
    @wbinnssmith
    wbinnssmith committed Oct 5, 2023
    Copy the full SHA
    fb9878a View commit details
    Browse the repository at this point in the history

  9. fixup! Add test for using external node_modules for pages

    @wbinnssmith
    wbinnssmith committed Oct 5, 2023
    Copy the full SHA
    e8a27f6 View commit details
    Browse the repository at this point in the history

  10. Merge remote-tracking branch 'origin/wbinnssmith/pages-external' into… 

    … wbinnssmith/app-external
    @wbinnssmith
    wbinnssmith committed Oct 5, 2023
    Copy the full SHA
    7f516f3 View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2023

  1. fixup! Turbopack + app router: always use externals for predefined pa… 

    …ckages
    @wbinnssmith
    wbinnssmith committed Oct 6, 2023
    Copy the full SHA
    f9cafbc View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/canary' into wbinnssmith/app-ext… 

    …ernal
    @wbinnssmith
    wbinnssmith committed Oct 6, 2023
    Copy the full SHA
    2ffc50c View commit details
    Browse the repository at this point in the history

  3. Merge branch 'canary' into wbinnssmith/app-external

    @kodiakhq
    kodiakhq[bot] committed Oct 6, 2023
    Copy the full SHA
    5380705 View commit details
    Browse the repository at this point in the history