-
Notifications
You must be signed in to change notification settings - Fork 26.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Leverage defineEnv for all environment variables in Turbopack #57196
Merged
timneutkens
merged 8 commits into
canary
from
10-21-Leverage_defineEnv_for_all_environment_variables_in_Turbopack
Oct 22, 2023
Merged
Leverage defineEnv for all environment variables in Turbopack #57196
timneutkens
merged 8 commits into
canary
from
10-21-Leverage_defineEnv_for_all_environment_variables_in_Turbopack
Oct 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timneutkens
requested review from
ijjk,
shuding,
huozhi,
a team,
feedthejim,
ztanner and
wyattjoh
as code owners
October 21, 2023 21:39
ijjk
added
area: tests
Turbopack
Related to Turbopack with Next.js.
created-by: Next.js team
PRs by the Next.js team
type: next
labels
Oct 21, 2023
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
Tests Passed |
Stats from current PRDefault BuildGeneral Overall increase
|
vercel/next.js canary | vercel/next.js 10-21-Leverage_defineEnv_for_all_environment_variables_in_Turbopack | Change | |
---|---|---|---|
buildDuration | 10.4s | 10.5s | N/A |
buildDurationCached | 6.1s | 6s | N/A |
nodeModulesSize | 174 MB | 174 MB | |
nextStartRea..uration (ms) | 512ms | 511ms | N/A |
Client Bundles (main, webpack)
vercel/next.js canary | vercel/next.js 10-21-Leverage_defineEnv_for_all_environment_variables_in_Turbopack | Change | |
---|---|---|---|
199-HASH.js gzip | 27.6 kB | 27.7 kB | N/A |
3f784ff6-HASH.js gzip | 53.3 kB | 53.3 kB | ✓ |
99.HASH.js gzip | 182 B | 182 B | ✓ |
framework-HASH.js gzip | 45.3 kB | 45.3 kB | ✓ |
main-app-HASH.js gzip | 254 B | 250 B | N/A |
main-HASH.js gzip | 32.9 kB | 32.9 kB | N/A |
webpack-HASH.js gzip | 1.75 kB | 1.75 kB | N/A |
Overall change | 98.8 kB | 98.8 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | vercel/next.js 10-21-Leverage_defineEnv_for_all_environment_variables_in_Turbopack | Change | |
---|---|---|---|
polyfills-HASH.js gzip | 31 kB | 31 kB | ✓ |
Overall change | 31 kB | 31 kB | ✓ |
Client Pages
vercel/next.js canary | vercel/next.js 10-21-Leverage_defineEnv_for_all_environment_variables_in_Turbopack | Change | |
---|---|---|---|
_app-HASH.js gzip | 206 B | 205 B | N/A |
_error-HASH.js gzip | 182 B | 180 B | N/A |
amp-HASH.js gzip | 506 B | 505 B | N/A |
css-HASH.js gzip | 322 B | 323 B | N/A |
dynamic-HASH.js gzip | 2.57 kB | 2.57 kB | N/A |
edge-ssr-HASH.js gzip | 260 B | 259 B | N/A |
head-HASH.js gzip | 350 B | 350 B | ✓ |
hooks-HASH.js gzip | 369 B | 369 B | ✓ |
image-HASH.js gzip | 4.36 kB | 4.36 kB | N/A |
index-HASH.js gzip | 256 B | 256 B | ✓ |
link-HASH.js gzip | 2.64 kB | 2.63 kB | N/A |
routerDirect..HASH.js gzip | 312 B | 311 B | N/A |
script-HASH.js gzip | 385 B | 384 B | N/A |
withRouter-HASH.js gzip | 307 B | 308 B | N/A |
1afbb74e6ecf..834.css gzip | 106 B | 106 B | ✓ |
Overall change | 1.08 kB | 1.08 kB | ✓ |
Client Build Manifests
vercel/next.js canary | vercel/next.js 10-21-Leverage_defineEnv_for_all_environment_variables_in_Turbopack | Change | |
---|---|---|---|
_buildManifest.js gzip | 484 B | 482 B | N/A |
Overall change | 0 B | 0 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | vercel/next.js 10-21-Leverage_defineEnv_for_all_environment_variables_in_Turbopack | Change | |
---|---|---|---|
index.html gzip | 529 B | 528 B | N/A |
link.html gzip | 541 B | 543 B | N/A |
withRouter.html gzip | 523 B | 522 B | N/A |
Overall change | 0 B | 0 B | ✓ |
Edge SSR bundle Size
vercel/next.js canary | vercel/next.js 10-21-Leverage_defineEnv_for_all_environment_variables_in_Turbopack | Change | |
---|---|---|---|
edge-ssr.js gzip | 93.8 kB | 93.8 kB | N/A |
page.js gzip | 155 kB | 155 kB | N/A |
Overall change | 0 B | 0 B | ✓ |
Middleware size
vercel/next.js canary | vercel/next.js 10-21-Leverage_defineEnv_for_all_environment_variables_in_Turbopack | Change | |
---|---|---|---|
middleware-b..fest.js gzip | 625 B | 623 B | N/A |
middleware-r..fest.js gzip | 150 B | 151 B | N/A |
middleware.js gzip | 22.9 kB | 22.9 kB | N/A |
edge-runtime..pack.js gzip | 1.92 kB | 1.92 kB | ✓ |
Overall change | 1.92 kB | 1.92 kB | ✓ |
Still failing |
sokra
reviewed
Oct 22, 2023
Comment on lines
+66
to
83
fn defines(define_env: &IndexMap<String, String>) -> CompileTimeDefines { | ||
let mut defines = IndexMap::new(); | ||
|
||
for (k, v) in define_env { | ||
defines | ||
.0 | ||
.entry(k.split('.').map(|s| s.to_string()).collect()) | ||
.or_insert_with(|| CompileTimeDefineValue::JSON(v.clone())); | ||
.entry(k.split('.').map(|s| s.to_string()).collect::<Vec<String>>()) | ||
.or_insert_with(|| { | ||
let val = serde_json::from_str(v); | ||
match val { | ||
Ok(serde_json::Value::Bool(v)) => CompileTimeDefineValue::Bool(v), | ||
Ok(serde_json::Value::String(v)) => CompileTimeDefineValue::String(v), | ||
_ => CompileTimeDefineValue::JSON(v.clone()), | ||
} | ||
}); | ||
} | ||
|
||
defines | ||
CompileTimeDefines(defines) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be moved into a shared files
timneutkens
deleted the
10-21-Leverage_defineEnv_for_all_environment_variables_in_Turbopack
branch
October 22, 2023 22:37
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
created-by: Next.js team
PRs by the Next.js team
locked
Turbopack
Related to Turbopack with Next.js.
type: next
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures all
process.env
replacement comes from define-env in Next.js, instead of also applying it partially on the Rust side.