Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable opentelemetry test in turbopack #57361

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

ztanner
Copy link
Member

@ztanner ztanner commented Oct 24, 2023

experimental.instrumentationHook is not currently supported by Turbopack, so this skips the tests.

@ijjk ijjk added area: tests created-by: Next.js team PRs by the Next.js team labels Oct 24, 2023
@ztanner ztanner marked this pull request as ready for review October 24, 2023 21:00
@ztanner ztanner force-pushed the tests/disable-openetelemetry-test branch from 71ad590 to 35fb801 Compare October 24, 2023 21:00
@ijjk
Copy link
Member

ijjk commented Oct 24, 2023

Stats from current PR

Default Build
General
vercel/next.js canary vercel/next.js tests/disable-openetelemetry-test Change
buildDuration 10.4s 10.3s N/A
buildDurationCached 6s 6.1s N/A
nodeModulesSize 175 MB 175 MB
nextStartRea..uration (ms) 422ms 413ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js tests/disable-openetelemetry-test Change
199-HASH.js gzip 32.3 kB 32.3 kB N/A
3f784ff6-HASH.js gzip 53.2 kB 53.2 kB N/A
99.HASH.js gzip 182 B 182 B
framework-HASH.js gzip 45.5 kB 45.5 kB
main-app-HASH.js gzip 254 B 251 B N/A
main-HASH.js gzip 35.3 kB 35.4 kB N/A
webpack-HASH.js gzip 1.75 kB 1.75 kB N/A
Overall change 45.7 kB 45.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js tests/disable-openetelemetry-test Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js tests/disable-openetelemetry-test Change
_app-HASH.js gzip 206 B 205 B N/A
_error-HASH.js gzip 182 B 180 B N/A
amp-HASH.js gzip 506 B 505 B N/A
css-HASH.js gzip 322 B 323 B N/A
dynamic-HASH.js gzip 2.59 kB 2.59 kB
edge-ssr-HASH.js gzip 260 B 259 B N/A
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 369 B 369 B
image-HASH.js gzip 4.38 kB 4.38 kB N/A
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.67 kB 2.67 kB N/A
routerDirect..HASH.js gzip 316 B 318 B N/A
script-HASH.js gzip 385 B 384 B N/A
withRouter-HASH.js gzip 319 B 319 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.99 kB 3.99 kB
Client Build Manifests
vercel/next.js canary vercel/next.js tests/disable-openetelemetry-test Change
_buildManifest.js gzip 484 B 482 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js tests/disable-openetelemetry-test Change
index.html gzip 528 B 531 B N/A
link.html gzip 542 B 542 B
withRouter.html gzip 524 B 524 B
Overall change 1.07 kB 1.07 kB
Edge SSR bundle Size
vercel/next.js canary vercel/next.js tests/disable-openetelemetry-test Change
edge-ssr.js gzip 96 kB 96 kB N/A
page.js gzip 139 kB 139 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js tests/disable-openetelemetry-test Change
middleware-b..fest.js gzip 623 B 625 B N/A
middleware-r..fest.js gzip 150 B 151 B N/A
middleware.js gzip 25.8 kB 25.8 kB N/A
edge-runtime..pack.js gzip 1.92 kB 1.92 kB
Overall change 1.92 kB 1.92 kB
Commit: 35fb801

@timneutkens timneutkens merged commit d6a933e into canary Oct 24, 2023
53 of 58 checks passed
@timneutkens timneutkens deleted the tests/disable-openetelemetry-test branch October 24, 2023 21:15
@github-actions github-actions bot added the locked label Nov 8, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants