Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix should have correct module not found error test #57383

Merged

Conversation

timneutkens
Copy link
Member

The module not found check is a bit different in Turbopack.

@timneutkens
Copy link
Member Author

timneutkens commented Oct 25, 2023

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@ijjk
Copy link
Member

ijjk commented Oct 25, 2023

Tests Passed

@ijjk
Copy link
Member

ijjk commented Oct 25, 2023

Stats from current PR

Default Build
General
vercel/next.js canary vercel/next.js 10-24-Fix_should_have_correct_module_not_found_error_test Change
buildDuration 10.8s 10.7s N/A
buildDurationCached 6.1s 8s ⚠️ +1.9s
nodeModulesSize 175 MB 175 MB
nextStartRea..uration (ms) 396ms 399ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js 10-24-Fix_should_have_correct_module_not_found_error_test Change
199-HASH.js gzip 30.4 kB 30.5 kB N/A
3f784ff6-HASH.js gzip 53.2 kB 53.2 kB
494.HASH.js gzip 182 B 182 B
framework-HASH.js gzip 45.5 kB 45.5 kB
main-app-HASH.js gzip 252 B 251 B N/A
main-HASH.js gzip 33 kB 33 kB N/A
webpack-HASH.js gzip 1.75 kB 1.75 kB N/A
Overall change 98.9 kB 98.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js 10-24-Fix_should_have_correct_module_not_found_error_test Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js 10-24-Fix_should_have_correct_module_not_found_error_test Change
_app-HASH.js gzip 205 B 205 B
_error-HASH.js gzip 182 B 181 B N/A
amp-HASH.js gzip 505 B 507 B N/A
css-HASH.js gzip 322 B 323 B N/A
dynamic-HASH.js gzip 2.59 kB 2.59 kB N/A
edge-ssr-HASH.js gzip 258 B 259 B N/A
head-HASH.js gzip 348 B 347 B N/A
hooks-HASH.js gzip 369 B 368 B N/A
image-HASH.js gzip 4.38 kB 4.38 kB N/A
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.71 kB 2.7 kB N/A
routerDirect..HASH.js gzip 318 B 318 B
script-HASH.js gzip 384 B 383 B N/A
withRouter-HASH.js gzip 319 B 320 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 885 B 885 B
Client Build Manifests
vercel/next.js canary vercel/next.js 10-24-Fix_should_have_correct_module_not_found_error_test Change
_buildManifest.js gzip 483 B 484 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js 10-24-Fix_should_have_correct_module_not_found_error_test Change
index.html gzip 526 B 528 B N/A
link.html gzip 540 B 540 B
withRouter.html gzip 522 B 523 B N/A
Overall change 540 B 540 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js 10-24-Fix_should_have_correct_module_not_found_error_test Change
edge-ssr.js gzip 96.7 kB 96.7 kB N/A
page.js gzip 141 kB 141 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js 10-24-Fix_should_have_correct_module_not_found_error_test Change
middleware-b..fest.js gzip 624 B 627 B N/A
middleware-r..fest.js gzip 148 B 151 B N/A
middleware.js gzip 24.8 kB 24.8 kB N/A
edge-runtime..pack.js gzip 1.92 kB 1.92 kB
Overall change 1.92 kB 1.92 kB
Next Runtimes
vercel/next.js canary vercel/next.js 10-24-Fix_should_have_correct_module_not_found_error_test Change
app-page-exp...dev.js gzip 167 kB 167 kB
app-page-exp..prod.js gzip 94.5 kB 94.5 kB
app-page-tur..prod.js gzip 95.2 kB 95.2 kB
app-page-tur..prod.js gzip 89.9 kB 89.9 kB
app-page.run...dev.js gzip 137 kB 137 kB
app-page.run..prod.js gzip 89.2 kB 89.2 kB
app-route-ex...dev.js gzip 23.5 kB 23.5 kB
app-route-ex..prod.js gzip 16.4 kB 16.4 kB
app-route-tu..prod.js gzip 16.4 kB 16.4 kB
app-route-tu..prod.js gzip 16 kB 16 kB
app-route.ru...dev.js gzip 22.9 kB 22.9 kB
app-route.ru..prod.js gzip 16 kB 16 kB
pages-api-tu..prod.js gzip 9.37 kB 9.37 kB
pages-api.ru...dev.js gzip 9.64 kB 9.64 kB
pages-api.ru..prod.js gzip 9.37 kB 9.37 kB
pages-turbo...prod.js gzip 21.5 kB 21.5 kB
pages.runtim...dev.js gzip 22.2 kB 22.2 kB
pages.runtim..prod.js gzip 21.5 kB 21.5 kB
server.runti..prod.js gzip 48.5 kB 48.5 kB
Overall change 926 kB 926 kB
Commit: e741e14

@timneutkens timneutkens force-pushed the 10-24-Fix_should_have_correct_module_not_found_error_test branch from e741e14 to 9cd16c5 Compare November 5, 2023 17:40
@timneutkens timneutkens merged commit aedd858 into canary Nov 5, 2023
56 of 59 checks passed
@timneutkens timneutkens deleted the 10-24-Fix_should_have_correct_module_not_found_error_test branch November 5, 2023 17:57
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants