Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codemods: migrate viewport related metadata export to viewport export #57436

Merged
merged 2 commits into from
Oct 25, 2023

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Oct 25, 2023

This PR adds the codemods transforming certain fields from metadata export to viewport export, will still preserve rest metadata export properties. We don't cover generateMetadata to generateViewport as there might be more complex logic inside the function which is hard to apply the codemods rules.

TLDR: Codemods for #57302

@ijjk
Copy link
Member

ijjk commented Oct 25, 2023

Stats from current PR

Default Build
General
vercel/next.js canary vercel/next.js codemods/viewport-api Change
buildDuration 10.3s 10.6s ⚠️ +285ms
buildDurationCached 6s 6.1s N/A
nodeModulesSize 175 MB 175 MB
nextStartRea..uration (ms) 418ms 421ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js codemods/viewport-api Change
199-HASH.js gzip 32.4 kB 32.4 kB N/A
3f784ff6-HASH.js gzip 53.2 kB 53.2 kB N/A
99.HASH.js gzip 182 B 182 B
framework-HASH.js gzip 45.5 kB 45.5 kB
main-app-HASH.js gzip 254 B 252 B N/A
main-HASH.js gzip 35.3 kB 35.4 kB N/A
webpack-HASH.js gzip 1.75 kB 1.75 kB N/A
Overall change 45.7 kB 45.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js codemods/viewport-api Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js codemods/viewport-api Change
_app-HASH.js gzip 206 B 205 B N/A
_error-HASH.js gzip 182 B 180 B N/A
amp-HASH.js gzip 506 B 505 B N/A
css-HASH.js gzip 322 B 323 B N/A
dynamic-HASH.js gzip 2.59 kB 2.59 kB
edge-ssr-HASH.js gzip 260 B 259 B N/A
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 369 B 369 B
image-HASH.js gzip 4.38 kB 4.38 kB N/A
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.67 kB 2.67 kB N/A
routerDirect..HASH.js gzip 316 B 318 B N/A
script-HASH.js gzip 385 B 384 B N/A
withRouter-HASH.js gzip 319 B 319 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.99 kB 3.99 kB
Client Build Manifests
vercel/next.js canary vercel/next.js codemods/viewport-api Change
_buildManifest.js gzip 484 B 482 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js codemods/viewport-api Change
index.html gzip 528 B 529 B N/A
link.html gzip 542 B 542 B
withRouter.html gzip 524 B 524 B
Overall change 1.07 kB 1.07 kB
Edge SSR bundle Size
vercel/next.js canary vercel/next.js codemods/viewport-api Change
edge-ssr.js gzip 96 kB 96 kB N/A
page.js gzip 140 kB 140 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js codemods/viewport-api Change
middleware-b..fest.js gzip 623 B 621 B N/A
middleware-r..fest.js gzip 150 B 151 B N/A
middleware.js gzip 25.8 kB 25.8 kB N/A
edge-runtime..pack.js gzip 1.92 kB 1.92 kB
Overall change 1.92 kB 1.92 kB
Commit: 0255fbf

@huozhi huozhi marked this pull request as ready for review October 25, 2023 18:53
@huozhi huozhi requested review from timeyoutakeit and molebox and removed request for a team October 25, 2023 18:53
@ijjk
Copy link
Member

ijjk commented Oct 25, 2023

Tests Passed

ztanner
ztanner previously approved these changes Oct 25, 2023
@shuding shuding merged commit 164e439 into canary Oct 25, 2023
53 of 58 checks passed
@shuding shuding deleted the codemods/viewport-api branch October 25, 2023 23:02
@huozhi huozhi mentioned this pull request Oct 25, 2023
@landsman
Copy link
Contributor

landsman commented Nov 7, 2023

@leerob Please update this blog post with instructions on how to do the update, including running these codemods.
It have to be very hard for people who are not aware of the existence this kind of thing.

This is just not enough:
Screenshot 2023-11-07 at 12 11 21

I can imagine npm script which will do the update with running codemods for the new version out of the box, what do you think?

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants