Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't terminate PPR renders with dynamicUsageErr #57488

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

sebmarkbage
Copy link
Contributor

@sebmarkbage sebmarkbage commented Oct 26, 2023

We track dynamicUsageErr in patch-fetch usually and then abort the whole prerender if that happens. With PPR we use maybePostpone and not that so we should just not abort when we use ppr.

@ijjk
Copy link
Member

ijjk commented Oct 26, 2023

Stats from current PR

Default Build
General Overall increase ⚠️
vercel/next.js canary sebmarkbage/next.js pprfix Change
buildDuration 13.2s 13.3s N/A
buildDurationCached 7.9s 8s N/A
nodeModulesSize 175 MB 175 MB ⚠️ +1.74 kB
nextStartRea..uration (ms) 477ms 466ms N/A
Client Bundles (main, webpack)
vercel/next.js canary sebmarkbage/next.js pprfix Change
199-HASH.js gzip 32.3 kB 32.4 kB N/A
3f784ff6-HASH.js gzip 53.2 kB 53.2 kB
99.HASH.js gzip 182 B 182 B
framework-HASH.js gzip 45.5 kB 45.5 kB
main-app-HASH.js gzip 253 B 252 B N/A
main-HASH.js gzip 35.3 kB 35.4 kB N/A
webpack-HASH.js gzip 1.75 kB 1.75 kB N/A
Overall change 98.9 kB 98.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary sebmarkbage/next.js pprfix Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary sebmarkbage/next.js pprfix Change
_app-HASH.js gzip 206 B 205 B N/A
_error-HASH.js gzip 182 B 180 B N/A
amp-HASH.js gzip 506 B 505 B N/A
css-HASH.js gzip 322 B 323 B N/A
dynamic-HASH.js gzip 2.59 kB 2.59 kB
edge-ssr-HASH.js gzip 260 B 259 B N/A
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 369 B 369 B
image-HASH.js gzip 4.38 kB 4.38 kB N/A
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.67 kB 2.67 kB N/A
routerDirect..HASH.js gzip 316 B 318 B N/A
script-HASH.js gzip 385 B 384 B N/A
withRouter-HASH.js gzip 319 B 319 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.99 kB 3.99 kB
Client Build Manifests
vercel/next.js canary sebmarkbage/next.js pprfix Change
_buildManifest.js gzip 484 B 482 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary sebmarkbage/next.js pprfix Change
index.html gzip 529 B 530 B N/A
link.html gzip 543 B 543 B
withRouter.html gzip 525 B 524 B N/A
Overall change 543 B 543 B
Edge SSR bundle Size
vercel/next.js canary sebmarkbage/next.js pprfix Change
edge-ssr.js gzip 96 kB 96 kB N/A
page.js gzip 140 kB 140 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary sebmarkbage/next.js pprfix Change
middleware-b..fest.js gzip 622 B 622 B
middleware-r..fest.js gzip 150 B 151 B N/A
middleware.js gzip 25.6 kB 25.6 kB N/A
edge-runtime..pack.js gzip 1.92 kB 1.92 kB
Overall change 2.54 kB 2.54 kB
Diff details
Diff for page.js

Diff too large to display

Commit: 07c5fdc

@sebmarkbage sebmarkbage merged commit d396631 into vercel:canary Oct 26, 2023
51 of 56 checks passed
@github-actions github-actions bot added the locked label Nov 9, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants