Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples: cleanup #57845

Merged
merged 2 commits into from
Nov 1, 2023
Merged

examples: cleanup #57845

merged 2 commits into from
Nov 1, 2023

Conversation

leerob
Copy link
Member

@leerob leerob commented Nov 1, 2023

Remove examples that were linking to just READMEs, or outdated / discontinued ones.

@leerob leerob requested review from jh3y and molebox and removed request for a team November 1, 2023 00:06
@ijjk ijjk added examples Issue/PR related to examples created-by: Next.js DevEx team labels Nov 1, 2023
@kodiakhq kodiakhq bot merged commit ac54377 into canary Nov 1, 2023
53 checks passed
@kodiakhq kodiakhq bot deleted the examples-amplify branch November 1, 2023 00:08
@cassus
Copy link

cassus commented Nov 1, 2023

Hi! The ESM example (examples/hello-world-esm) was helpful for me. Is there an alternative for that or maybe a documentation that explains how to make nextJS work in an ESM package?

@leerob
Copy link
Member Author

leerob commented Nov 1, 2023

It was a single line difference "type": "module" in the package.json AFAIK.

@cassus
Copy link

cassus commented Nov 1, 2023

Yeah, I see why an example might be overkill in this case.

Is there any mention that this is all that is required and that NextJS supports running in this way? I couldn't find it, it might be useful for others. Just a suggestion, up to you @leerob

@darrellwarde
Copy link

darrellwarde commented Nov 15, 2023

Hi @leerob, my name is Darrell, I work on the GraphQL team at Neo4j. I see that you deleted with-apollo-neo4j-graphql example in this PR. This is an example we linked to from our documentation, which is now broken.

Whilst I will be the first to admit we weren't actively maintaining the example, we weren't aware of it falling massively out of date, especially as it was only brought up to date in February (#44570).

I understand the desire to have a clean set of examples, but a heads up on this would have been appreciated so that we could have at least had the opportunity to address any issues.

Could you please give some guidance on how we can have this reintroduced, and how we can avoid our example being deleted in future?

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants