Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure cache soft tags are correct #57850

Merged
merged 2 commits into from
Nov 1, 2023
Merged

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Nov 1, 2023

We noticed that our internal soft tags were unexpectedly including the query string for SSR routes which causes the URL soft tag to not match correctly so this ensures we properly normalize the value to just the pathname and not include the query.

@ijjk
Copy link
Member Author

ijjk commented Nov 1, 2023

Stats from current PR

Default Build
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/ssr-soft-tags Change
buildDuration 10.8s 10.8s N/A
buildDurationCached 6.2s 6.9s ⚠️ +715ms
nodeModulesSize 175 MB 175 MB ⚠️ +8.17 kB
nextStartRea..uration (ms) 402ms 399ms N/A
Client Bundles (main, webpack)
vercel/next.js canary ijjk/next.js fix/ssr-soft-tags Change
199-HASH.js gzip 30 kB 30 kB N/A
3f784ff6-HASH.js gzip 53.2 kB 53.2 kB
494.HASH.js gzip 182 B 182 B
framework-HASH.js gzip 45.5 kB 45.5 kB
main-app-HASH.js gzip 254 B 252 B N/A
main-HASH.js gzip 33.1 kB 33.1 kB N/A
webpack-HASH.js gzip 1.75 kB 1.75 kB N/A
Overall change 98.9 kB 98.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/ssr-soft-tags Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js fix/ssr-soft-tags Change
_app-HASH.js gzip 205 B 205 B
_error-HASH.js gzip 182 B 181 B N/A
amp-HASH.js gzip 505 B 507 B N/A
css-HASH.js gzip 322 B 323 B N/A
dynamic-HASH.js gzip 2.59 kB 2.59 kB N/A
edge-ssr-HASH.js gzip 258 B 259 B N/A
head-HASH.js gzip 348 B 347 B N/A
hooks-HASH.js gzip 369 B 368 B N/A
image-HASH.js gzip 4.38 kB 4.38 kB N/A
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.67 kB 2.67 kB N/A
routerDirect..HASH.js gzip 318 B 318 B
script-HASH.js gzip 384 B 383 B N/A
withRouter-HASH.js gzip 319 B 320 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 885 B 885 B
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/ssr-soft-tags Change
_buildManifest.js gzip 484 B 484 B
Overall change 484 B 484 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/ssr-soft-tags Change
index.html gzip 529 B 528 B N/A
link.html gzip 541 B 543 B N/A
withRouter.html gzip 525 B 524 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js canary ijjk/next.js fix/ssr-soft-tags Change
edge-ssr.js gzip 96.1 kB 96.1 kB N/A
page.js gzip 140 kB 140 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary ijjk/next.js fix/ssr-soft-tags Change
middleware-b..fest.js gzip 625 B 627 B N/A
middleware-r..fest.js gzip 148 B 151 B N/A
middleware.js gzip 23 kB 23 kB
edge-runtime..pack.js gzip 1.92 kB 1.92 kB
Overall change 25 kB 25 kB
Diff details
Diff for page.js

Diff too large to display

Commit: 1a778b9

@kodiakhq kodiakhq bot merged commit 03ca164 into vercel:canary Nov 1, 2023
56 checks passed
@ijjk ijjk deleted the fix/ssr-soft-tags branch November 1, 2023 02:02
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants