Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: always use SWC Wasm fallback when running in WebContainer #58081

Merged
merged 3 commits into from
Nov 6, 2023

Conversation

d3lm
Copy link
Contributor

@d3lm d3lm commented Nov 6, 2023

What?

Since the Wasm fallback was re-introduced in #57906 I am now also adding a check for detecting WebContainers so that it would always use the SWC Wasm fallback. That's because WebContainers can't execute native binaries.

I decided to not account for NEXT_DISABLE_SWC_WASM because it doesn't make much sense and if someone had this enabled, it would always fail. But if ya all think it's better to take this flag into account then I am happy to change it.

@ijjk
Copy link
Member

ijjk commented Nov 6, 2023

Allow CI Workflow Run

  • approve CI run for commit: 8eaa762

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

1 similar comment
@ijjk
Copy link
Member

ijjk commented Nov 6, 2023

Allow CI Workflow Run

  • approve CI run for commit: 8eaa762

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@ijjk
Copy link
Member

ijjk commented Nov 6, 2023

Allow CI Workflow Run

  • approve CI run for commit: 8eaa762

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

1 similar comment
@ijjk
Copy link
Member

ijjk commented Nov 6, 2023

Allow CI Workflow Run

  • approve CI run for commit: 8eaa762

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@d3lm
Copy link
Contributor Author

d3lm commented Nov 6, 2023

CC @kwonoj @jridgewell

@timneutkens timneutkens added the CI approved Approve running CI for fork label Nov 6, 2023
@ijjk
Copy link
Member

ijjk commented Nov 6, 2023

Stats from current PR

Default Build
General Overall increase ⚠️
vercel/next.js canary d3lm/next.js d3lm/add-webcontainer-detection Change
buildDuration 10.6s 10.7s N/A
buildDurationCached 6s 6.7s ⚠️ +705ms
nodeModulesSize 175 MB 175 MB ⚠️ +726 B
nextStartRea..uration (ms) 399ms 398ms N/A
Client Bundles (main, webpack)
vercel/next.js canary d3lm/next.js d3lm/add-webcontainer-detection Change
199-HASH.js gzip 30.4 kB 30.5 kB N/A
3f784ff6-HASH.js gzip 53.2 kB 53.2 kB
494.HASH.js gzip 182 B 182 B
framework-HASH.js gzip 45.5 kB 45.5 kB
main-app-HASH.js gzip 254 B 252 B N/A
main-HASH.js gzip 33 kB 33 kB N/A
webpack-HASH.js gzip 1.75 kB 1.75 kB N/A
Overall change 98.9 kB 98.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary d3lm/next.js d3lm/add-webcontainer-detection Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary d3lm/next.js d3lm/add-webcontainer-detection Change
_app-HASH.js gzip 205 B 205 B
_error-HASH.js gzip 182 B 181 B N/A
amp-HASH.js gzip 505 B 507 B N/A
css-HASH.js gzip 322 B 323 B N/A
dynamic-HASH.js gzip 2.59 kB 2.59 kB N/A
edge-ssr-HASH.js gzip 258 B 259 B N/A
head-HASH.js gzip 348 B 347 B N/A
hooks-HASH.js gzip 369 B 368 B N/A
image-HASH.js gzip 4.38 kB 4.38 kB N/A
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.71 kB 2.7 kB N/A
routerDirect..HASH.js gzip 318 B 318 B
script-HASH.js gzip 384 B 383 B N/A
withRouter-HASH.js gzip 319 B 320 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 885 B 885 B
Client Build Manifests
vercel/next.js canary d3lm/next.js d3lm/add-webcontainer-detection Change
_buildManifest.js gzip 483 B 484 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary d3lm/next.js d3lm/add-webcontainer-detection Change
index.html gzip 528 B 527 B N/A
link.html gzip 540 B 542 B N/A
withRouter.html gzip 523 B 522 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js canary d3lm/next.js d3lm/add-webcontainer-detection Change
edge-ssr.js gzip 96.7 kB 96.7 kB N/A
page.js gzip 141 kB 141 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary d3lm/next.js d3lm/add-webcontainer-detection Change
middleware-b..fest.js gzip 625 B 625 B
middleware-r..fest.js gzip 148 B 151 B N/A
middleware.js gzip 24.8 kB 24.8 kB N/A
edge-runtime..pack.js gzip 1.92 kB 1.92 kB
Overall change 2.55 kB 2.55 kB
Next Runtimes
vercel/next.js canary d3lm/next.js d3lm/add-webcontainer-detection Change
app-page-exp...dev.js gzip 167 kB 167 kB
app-page-exp..prod.js gzip 94.5 kB 94.5 kB
app-page-tur..prod.js gzip 95.2 kB 95.2 kB
app-page-tur..prod.js gzip 89.9 kB 89.9 kB
app-page.run...dev.js gzip 137 kB 137 kB
app-page.run..prod.js gzip 89.2 kB 89.2 kB
app-route-ex...dev.js gzip 23.5 kB 23.5 kB
app-route-ex..prod.js gzip 16.4 kB 16.4 kB
app-route-tu..prod.js gzip 16.4 kB 16.4 kB
app-route-tu..prod.js gzip 16 kB 16 kB
app-route.ru...dev.js gzip 22.9 kB 22.9 kB
app-route.ru..prod.js gzip 16 kB 16 kB
pages-api-tu..prod.js gzip 9.37 kB 9.37 kB
pages-api.ru...dev.js gzip 9.64 kB 9.64 kB
pages-api.ru..prod.js gzip 9.37 kB 9.37 kB
pages-turbo...prod.js gzip 21.5 kB 21.5 kB
pages.runtim...dev.js gzip 22.2 kB 22.2 kB
pages.runtim..prod.js gzip 21.5 kB 21.5 kB
server.runti..prod.js gzip 48.5 kB 48.5 kB
Overall change 926 kB 926 kB
Commit: fdf5781

@ijjk
Copy link
Member

ijjk commented Nov 6, 2023

Tests Passed

@jridgewell jridgewell merged commit 103ca04 into vercel:canary Nov 6, 2023
59 checks passed
@d3lm d3lm deleted the d3lm/add-webcontainer-detection branch November 6, 2023 16:38
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI approved Approve running CI for fork locked type: next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants