Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Add lightningcss mode for turbopack-css #58471

Merged
merged 27 commits into from Nov 20, 2023
Merged

refactor: Add lightningcss mode for turbopack-css #58471

merged 27 commits into from Nov 20, 2023

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Nov 15, 2023

What?

We are experimenting with lightningcss. This is about replacing swc_css with lightningcss in turbopack, and the main reason for this is to reduce the maintenance burden.
But when I tried, it introduced several regressions, so I'm putting it behind an experimental flag.

You can enable lightningcss mode for turbopack by adding a flag to the next config file.

/**
 * @type {import('next').NextConfig}
 */
const nextConfig = {
  experimental: {
    useLightningcss: true,
  },
}

module.exports = nextConfig

Note that this is only for turbopack because we were not using swc_css for non-turbopack mode of next.js

x-ref: https://vercel.slack.com/archives/C03EWR7LGEN/p1700025496732229?thread_ts=1700019629.866549&cid=C03EWR7LGEN

Why?

We should avoid regressions.

How?


turbopack PR: vercel/turbo#6456

Closes PACK-1966

@kdy1 kdy1 self-assigned this Nov 15, 2023
@ijjk ijjk added Font (next/font) Related to Next.js Font Optimization. Turbopack Related to Turbopack with Next.js. created-by: Turbopack team PRs by the turbopack team type: next labels Nov 15, 2023
@ijjk
Copy link
Member

ijjk commented Nov 15, 2023

Tests Passed

@ijjk
Copy link
Member

ijjk commented Nov 15, 2023

Stats from current PR

Default Build
General Overall increase ⚠️
vercel/next.js canary vercel/next.js kdy1/css-mode Change
buildDuration 10.2s 10.4s ⚠️ +144ms
buildDurationCached 5.9s 5.8s N/A
nodeModulesSize 199 MB 199 MB ⚠️ +804 B
nextStartRea..uration (ms) 424ms 413ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js kdy1/css-mode Change
199-HASH.js gzip 28.7 kB 28.7 kB N/A
3f784ff6-HASH.js gzip 53.3 kB 53.3 kB
494.HASH.js gzip 180 B 181 B N/A
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 241 B 239 B N/A
main-HASH.js gzip 31.7 kB 31.7 kB N/A
webpack-HASH.js gzip 1.7 kB 1.7 kB
Overall change 100 kB 100 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js kdy1/css-mode Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js kdy1/css-mode Change
_app-HASH.js gzip 194 B 195 B N/A
_error-HASH.js gzip 182 B 181 B N/A
amp-HASH.js gzip 501 B 503 B N/A
css-HASH.js gzip 322 B 323 B N/A
dynamic-HASH.js gzip 2.5 kB 2.5 kB
edge-ssr-HASH.js gzip 253 B 255 B N/A
head-HASH.js gzip 348 B 347 B N/A
hooks-HASH.js gzip 369 B 368 B N/A
image-HASH.js gzip 4.28 kB 4.27 kB N/A
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.61 kB 2.6 kB N/A
routerDirect..HASH.js gzip 311 B 311 B
script-HASH.js gzip 384 B 383 B N/A
withRouter-HASH.js gzip 307 B 308 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.17 kB 3.17 kB
Client Build Manifests
vercel/next.js canary vercel/next.js kdy1/css-mode Change
_buildManifest.js gzip 484 B 483 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js kdy1/css-mode Change
index.html gzip 529 B 526 B N/A
link.html gzip 540 B 540 B
withRouter.html gzip 524 B 523 B N/A
Overall change 540 B 540 B
Edge SSR bundle Size
vercel/next.js canary vercel/next.js kdy1/css-mode Change
edge-ssr.js gzip 92.4 kB 92.4 kB N/A
page.js gzip 145 kB 145 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js kdy1/css-mode Change
middleware-b..fest.js gzip 626 B 625 B N/A
middleware-r..fest.js gzip 150 B 151 B N/A
middleware.js gzip 24.8 kB 24.8 kB N/A
edge-runtime..pack.js gzip 1.92 kB 1.92 kB
Overall change 1.92 kB 1.92 kB
Next Runtimes
vercel/next.js canary vercel/next.js kdy1/css-mode Change
app-page-exp...dev.js gzip 167 kB 167 kB
app-page-exp..prod.js gzip 93.4 kB 93.4 kB
app-page-tur..prod.js gzip 94.1 kB 94.1 kB
app-page-tur..prod.js gzip 88.7 kB 88.7 kB
app-page.run...dev.js gzip 137 kB 137 kB
app-page.run..prod.js gzip 88 kB 88 kB
app-route-ex...dev.js gzip 23.8 kB 23.8 kB
app-route-ex..prod.js gzip 16.4 kB 16.4 kB
app-route-tu..prod.js gzip 16.5 kB 16.5 kB
app-route-tu..prod.js gzip 16 kB 16 kB
app-route.ru...dev.js gzip 23.2 kB 23.2 kB
app-route.ru..prod.js gzip 16 kB 16 kB
pages-api-tu..prod.js gzip 9.37 kB 9.37 kB
pages-api.ru...dev.js gzip 9.64 kB 9.64 kB
pages-api.ru..prod.js gzip 9.37 kB 9.37 kB
pages-turbo...prod.js gzip 21.8 kB 21.8 kB
pages.runtim...dev.js gzip 22.5 kB 22.5 kB
pages.runtim..prod.js gzip 21.8 kB 21.8 kB
server.runti..prod.js gzip 49.1 kB 49.1 kB
Overall change 924 kB 924 kB
Commit: bb486d2

Copy link

socket-security bot commented Nov 17, 2023

No top level dependency changes detected. Learn more about Socket for GitHub ↗︎

sokra
sokra previously approved these changes Nov 19, 2023
Copy link
Member

@sokra sokra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add a basic test that set the use lightning CSS flag in next config with a basic css file

sokra
sokra previously approved these changes Nov 20, 2023
@kdy1 kdy1 marked this pull request as ready for review November 20, 2023 09:38
@kdy1 kdy1 requested a review from sokra November 20, 2023 09:38
sokra
sokra previously approved these changes Nov 20, 2023
…l-lightningcss.test.ts

Co-authored-by: Leah <github.leah@hrmny.sh>
@sokra sokra merged commit 94771bf into canary Nov 20, 2023
61 checks passed
@sokra sokra deleted the kdy1/css-mode branch November 20, 2023 17:09
@github-actions github-actions bot added the locked label Dec 5, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Turbopack team PRs by the turbopack team Font (next/font) Related to Next.js Font Optimization. locked Turbopack Related to Turbopack with Next.js. type: next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants